Setting Reserve Without Client Restart about clams

[dooglus]

I'm unable to reproduce this.

Please indicate how you trigger the problem, and what symptoms you see.

I added some debug and it appears to me that the change happens as soon as I click 'OK' or 'Apply' in the settings dialog:

nReserveBalance = 0.00 in CWallet::CreateCoinStake()
nReserveBalance = 0.00 in CWallet::CreateCoinStake()
nReserveBalance = 0.00 in CWallet::CreateCoinStake()
CHANGED Fee
CHANGED ReserveBalance
CHANGED StartAtStartup
nReserveBalance = 100.00 in CWallet::CreateCoinStake()
nReserveBalance = 100.00 in CWallet::CreateCoinStake()
nReserveBalance = 100.00 in CWallet::CreateCoinStake()
nReserveBalance = 100.00 in CWallet::CreateCoinStake()
nReserveBalance = 100.00 in CWallet::CreateCoinStake()
CHANGED Fee
CHANGED ReserveBalance
CHANGED StartAtStartup
nReserveBalance = 0.00 in CWallet::CreateCoinStake()
nReserveBalance = 0.00 in CWallet::CreateCoinStake()
nReserveBalance = 0.00 in CWallet::CreateCoinStake()

[dooglus]

Here are the changes I made to add the debug:

$ git diff
diff --git a/src/qt/optionsmodel.cpp b/src/qt/optionsmodel.cpp
index 14537e1..ae0ff79 100644
--- a/src/qt/optionsmodel.cpp
+++ b/src/qt/optionsmodel.cpp
@@ -193,6 +193,7 @@ bool OptionsModel::setData(const QModelIndex & index, const QVariant & value, in
         switch(index.row())
         {
         case StartAtStartup:
+            printf("CHANGED StartAtStartup\n");
             successful = GUIUtil::SetStartOnSystemStartup(value.toBool());
             break;
         case MinimizeToTray:
@@ -244,11 +245,13 @@ bool OptionsModel::setData(const QModelIndex & index, const QVariant & value, in
         }
         break;
         case Fee:
+            printf("CHANGED Fee\n");
             nTransactionFee = value.toLongLong();
             settings.setValue("nTransactionFee", (qint64) nTransactionFee);
             emit transactionFeeChanged(nTransactionFee);
             break;
         case ReserveBalance:
+            printf("CHANGED ReserveBalance\n");
             nReserveBalance = value.toLongLong();
             settings.setValue("nReserveBalance", (qint64) nReserveBalance);
             emit reserveBalanceChanged(nReserveBalance);
diff --git a/src/wallet.cpp b/src/wallet.cpp
index b267094..b7c9918 100644
--- a/src/wallet.cpp
+++ b/src/wallet.cpp
@@ -1597,6 +1597,8 @@ bool CWallet::GetExpectedStakeTime(uint64_t& nExpected)

 bool CWallet::CreateCoinStake(const CKeyStore& keystore, unsigned int nBits, int64_t nSearchInterval, int64_t nFees, CTransaction& txNew, CKey& key)
 {
+    printf("nReserveBalance = %s in CWallet::CreateCoinStake()\n", FormatMoney(nReserveBalance).c_str());
+
     CBlockIndex* pindexPrev = pindexBest;
     CBigNum bnTargetPerCoinDay;
     bnTargetPerCoinDay.SetCompact(nBits);

[l0rdicon]

Thank you for confirming this.

I had suggested to creative last night that the reserve did in fact update
without a reset but hadn't gotten to confirming it with debug.

Your stake weight updates in the ui which lead me to believe there was no
error.

Was the user issuing the command over rpc or from the user interface?

I'll test the rpc function when I get back to my computer

[dooglus]

I just tried the RPC function and it seems to work as intended.