GithubHelp home page GithubHelp logo

Comments (6)

l0rdicon avatar l0rdicon commented on August 16, 2024

Apparently this is already part of the client, you just need to have an encrypted wallet to see it.

Closing.

from clams.

dooglus avatar dooglus commented on August 16, 2024

I didn't know about that, so checked.

I use the RPC interface, not the GUI.

Encrypting your wallet removes this from the list of available commands:

encryptwallet <passphrase>

and adds these:

walletlock
walletpassphrase <passphrase> <timeout> [stakingonly]
walletpassphrasechange <oldpassphrase> <newpassphrase>

and here's the doc:

$ cc help walletpassphrase
walletpassphrase <passphrase> <timeout> [stakingonly]
Stores the wallet decryption key in memory for <timeout> seconds.
if [stakingonly] is true sending functions are disabled.

from clams.

dooglus avatar dooglus commented on August 16, 2024

I also noticed that "sending functions are disabled" isn't all:

$ cc dumpprivkey x96EFZRESguy2s8yd3D5Pybj8oZfGy62hG
error: {"code":-13,"message":"Error: Please enter the wallet passphrase with walletpassphrase first."}

$ cc walletpassphrase "$x" 60 true

$ cc dumpprivkey x96EFZRESguy2s8yd3D5Pybj8oZfGy62hG
error: {"code":-13,"message":"Error: Wallet is unlocked for staking only."}

I can't dump a private key when unlocked for staking only, either.

from clams.

l0rdicon avatar l0rdicon commented on August 16, 2024

That would be the correct behaviour it seems.

Most of the functionality should remain locked. It doesn't really provide
true protection as your still entering the master password so all the
normal avenues of attack would still work there, aka key loggers etc.

What it does do is allows you to 'unlock' your wallet without worrying
about someone potentially using your physical computer and sending from
your wallet. Rpc has other ways to be secured but it wouldn't hurt to leave
your wallet unlocked for staking and full fully unlock when you need access
the other functionality.
On Jul 25, 2014 2:33 PM, "Chris Moore" [email protected] wrote:

I also noticed that "sending functions are disabled" isn't all:

$ cc dumpprivkey x96EFZRESguy2s8yd3D5Pybj8oZfGy62hG
error: {"code":-13,"message":"Error: Please enter the wallet passphrase with walletpassphrase first."}

$ cc walletpassphrase "$x" 60 true

$ cc dumpprivkey x96EFZRESguy2s8yd3D5Pybj8oZfGy62hG
error: {"code":-13,"message":"Error: Wallet is unlocked for staking only."}

I can't dump a private key when unlocked for staking only, either.


Reply to this email directly or view it on GitHub
#7 (comment).

from clams.

dooglus avatar dooglus commented on August 16, 2024

Right, I wasn't saying the behaviour was wrong, just that it is kind of different than the documentation.

if [stakingonly] is true sending functions are disabled

would be better stated as something like:

if [stakingonly] is true decrypted private keys are only available for staking

Note that even without a keylogger it would be quite easy to use a debugger to change the value of fWalletUnlockStakingOnly from true to false in a running instance of the wallet. But any protection is better than none.

from clams.

l0rdicon avatar l0rdicon commented on August 16, 2024

Rereading I get that now. Head was still grogy from waking up.

I actually was thinking the same thing, the return message could be more
descript.

It's a quick change, I'll get it merged in to staging once I get the
staging branch cleaned up today.
On Jul 25, 2014 6:33 PM, "Chris Moore" [email protected] wrote:

Right, I wasn't saying the behaviour was wrong, just that it is kind of
different than the documentation.

if [stakingonly] is true sending functions are disabled

would be better stated as something like:

if [stakingonly] is true decrypted private keys are only available for staking

Note that even without a keylogger it would be quite easy to use a
debugger to change the value of fWalletUnlockStakingOnly from true to false
in a running instance of the wallet. But any protection is better than none.


Reply to this email directly or view it on GitHub
#7 (comment).

from clams.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.