DNS resolve errors and not mocking a lot of requests about nock

[b-brefeld]

@VladimirChuprazov

Here is a repo that reproduces the issue as requested:
https://bitbucket.org/brefeld-computers/nock-2575/src/main/

After cloning the repo run the following command:
npm install && npm run build && npm test
The test should fail.

Now change the "nock" version number to 13.5.0 in the package.json and run command:
npm run clean && npm install && npm run build && npm test
The test should now succeed.

If you need more info, you know where to find me

[mikicho]

You didn't end your request in your example. This is working for me:

request({method: 'GET', host: hostname, path: pathname, timeout: 5000}, (res) => {
    console.log(res.statusCode)
}).end();

[b-brefeld]

Dear Michael,

Thanks for your info.
I changed the code and tried again. (see: link)
I still have a failing test with nock on 13.5.1

Screenshot when using nock 13.5.0

Screenshot when using nock 13.5.1

You tried both versions and don't have this behavior?
I'm running on Ubuntu 22.04 if it makes any difference

[mikicho]

@b-brefeld This is because request is async. You should await for the response.

[b-brefeld]

@mikicho request does not return a Promise and I can't use await for it.
However I changed the code again to allow awaiting a response.
Please see the link

I still experience the same behaviour

[mikicho]

@b-brefeld are you using ESM?
If yes, your example imports the http module before nock does due to how ESM resolves and runs the code.
You can work around this like this:

import nock from 'nock';
const { request } = await import('http');

Another option is to import nock before:

node --import nock test.js

But, I recommend you use 3rd party libraries like axios or got instead of directly using the http module, which would probably solve this without your notice.

[VladimirChuprazov]

Hi @b-brefeld I just checked your reproduction repo, as @mikicho suggested, with both axios and got it works fine, I tried it.
Another option which @mikicho suggested is to run node --import nock test.js, if you want to run all your tests you can try:

node --import nock node_modules/.bin/jasmine

it works in your repo.