Comments (1)
So, it seems that the way we check the diff is not complete?
Here https://github.com/nocodb/nocodb/blob/develop/packages/nocodb/src/services/meta-diffs.service.ts#L244, we're checking just the type of the column. But in our case it's the same, enum, but different available options.
Apologies for the very crude/potentially wrong fix, but it seems that if we replace this condition
if (oldCol.dt !== column.dt) {
with something like:
if (oldCol.dt !== column.dt ||
oldCol.dt == 'enum' && oldCol.dtxp != column.dtxp
) {
It seems to fix the issue, and detect the change properly and is applied as expected.
Is this the right fix? Should I to submit a PR for this?
from nocodb.
Related Issues (20)
- π Bug: After each width adjustment of nc-sidebar, when the page is refreshed, the width changes to the default width
- π Bug: misc UI issues
- π Bug: Cannot connect to older version of MySQL
- π¦ Feature: Remove mentions for least used DB
- π Bug: NocoDB ignores end date for calendar view HOT 1
- π Bug: List API response delayed when pagination set to 100 HOT 1
- π Bug: When trying to add a new option in a Single select, the first option value is updated as well HOT 2
- π Bug: display value in new view οΌis not first column
- Question : Audit records only available for super user ? HOT 4
- π Bug: CSV Import error (Select options with an `'`)
- π¦ Feature: Import CSV - skip field mapping during import HOT 1
- π Bug: "Duplicate column alias" error with Airtable API quick import HOT 2
- π Bug: Noco-win-x64.exe After importing an image, the image cannot be previewed
- π Bug: User cannot see a base if added, removed, and re-added
- π¦ Feature: Show actual database error message on failed SQL operation
- π Bug: Undefined binding(s) detected when compiling SELECT when Link Records using API
- π Bug: formula modal UI/UX
- π Bug: Comments modal UI/UX HOT 1
- [Design] π Bug: expanded record UI/UX HOT 1
- [Design] π Bug: Group BY UI follow up's
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nocodb.