GithubHelp home page GithubHelp logo

Comments (1)

taeemo avatar taeemo commented on June 21, 2024

So, it seems that the way we check the diff is not complete?
Here https://github.com/nocodb/nocodb/blob/develop/packages/nocodb/src/services/meta-diffs.service.ts#L244, we're checking just the type of the column. But in our case it's the same, enum, but different available options.

Apologies for the very crude/potentially wrong fix, but it seems that if we replace this condition

 if (oldCol.dt !== column.dt) {

with something like:

if (oldCol.dt !== column.dt ||
          oldCol.dt == 'enum' && oldCol.dtxp != column.dtxp
        ) {

It seems to fix the issue, and detect the change properly and is applied as expected.

image
image

Is this the right fix? Should I to submit a PR for this?

from nocodb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.