GithubHelp home page GithubHelp logo

Comments (11)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 2, 2024

Original comment by jonathan.skeet on 17 Mar 2012 at 9:21

  • Added labels: V1-OutOfScope

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 2, 2024

Original comment by malcolm.rowe on 13 Jul 2012 at 8:33

  • Added labels: Type-Enhancement

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 2, 2024

Original comment by malcolm.rowe on 30 Jul 2012 at 7:47

  • Added labels: Milestone-1.1-consider
  • Removed labels: V1-OutOfScope

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 2, 2024
Is this still an issue?  I thought we were doing the first of those already 
("if you ask for an alias you get the exact same time zone object as the 
canonical one").

Original comment by malcolm.rowe on 10 Nov 2012 at 9:34

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 2, 2024
Yes, it's still an issue. I'd expected that behaviour, but we don't get it:

var provider = DateTimeZoneProviders.Tzdb;
Console.WriteLine(provider["Europe/Jersey"].Id); // Europe/Jersey

I'd have expected Europe/London. Hmm.

Original comment by jonathan.skeet on 10 Nov 2012 at 3:48

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 2, 2024
Right, the code is pretty simple. We have a dictionary in the resources, but 
when we ask for a time zone, we load it *from* the canonical name, but tell it 
that its ID was the one we asked for.

Given that this isn't something which applies to the BCL, I'm tempted to create 
an interface for "stuff which TZDB provides but isn't in all time zones" - 
which would expose a CanonicalId property to start with. We can very easily do 
this with no change in the resource format.

Original comment by jonathan.skeet on 10 Nov 2012 at 4:11

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 2, 2024
Suggestion for TzdbDateTimeZoneSource: we should expect it to have extra 
properties of:

- IDictionary<string, string> CanonicalIdMap (e.g. Europe/Jersey to 
Europe/London)

- Lookup<string, string> Aliases (e.g. Europe/London to { Europe/Jersey, 
Europe/Guernsey, Europe/Isle_of_Man })

- Lookup<string, string> SystemIdAliases (e.g. GMT Standard Time to { 
Europe/London, Atlantic/Canary, Atlantic/Faeroe, ... }) - see issue 82.

- IDictionary<string, string> SystemIdMap (e.g. Europe/London to GMT Standard 
Time)

Question: should an alias list include the canonical version, or just 
"different" aliases?

Original comment by jonathan.skeet on 11 Nov 2012 at 1:14

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 2, 2024
I've started implementing CanonicalIdMap and Aliases now; SystemIdAliases will 
require a format change, and therefore discussion on compatibility.

Original comment by jonathan.skeet on 11 Nov 2012 at 6:42

  • Changed state: Started

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 2, 2024
This issue was closed by revision 1a8208d3a4ce.

Original comment by jonathan.skeet on 11 Nov 2012 at 9:09

  • Changed state: Fixed

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 2, 2024
Note that this *doesn't* fix issue 82; that's still pending, but as it's 
already got its own issue, I see no reason to leave this one open.

Original comment by jonathan.skeet on 11 Nov 2012 at 9:24

from nodatime.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 2, 2024

Original comment by malcolm.rowe on 6 Apr 2013 at 9:27

  • Added labels: Milestone-1.1.0
  • Removed labels: Milestone-1.1-consider

from nodatime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.