Comments (7)
+1 from me
from abi-stable-node.
Discussed in the node-api team meeting this week. Lets think about it this week and the decide in the next meeting.
from abi-stable-node.
I think we should wait for nodejs/node#45715 as well.
from abi-stable-node.
We did forget this for a while, I think doing a new Node-API version would be good. We missed the lauch of Node.js 20 but I think we can get it in before it goes LTS.
from abi-stable-node.
Should we also put there the new finalizer behavior? Or they must be part of v10 as it is a quite big behavioral change?
from abi-stable-node.
We discussed today to do Release 9 with just
- node_api_symbol_for (https://github.com/nodejs/node/blob/master/src/js_native_api.h#L96)
- node_api_create_syntax_error (https://github.com/nodejs/node/blob/master/src/js_native_api.h#L120)
- node_api_throw_syntax_error (https://github.com/nodejs/node/blob/master/src/js_native_api.h#L377)
- node_api_get_module_file_name (https://github.com/nodejs/node/blob/master/src/node_api.h#L276)
along with nodejs/node#45715 and release those along with 45715 but modifying this line to guard with experimental - if (env->module_api_version <= 8) , as well as the documentation that says at what point the new functionality takes place, was well as the tests.
@vmoroz will submit a PR to makes those changes
@legendecas will do the the release. As part of that he will add to nodejs/node#47664
from abi-stable-node.
We have released Node-API version 9. Closing.
from abi-stable-node.
Related Issues (20)
- Ask for review of node-serialport Node-API port - https://github.com/serialport/node-serialport/pull/2305/files HOT 2
- Drive towards full coverage HOT 5
- Discuss Node-API addition https://github.com/nodejs/node/pull/41329#issuecomment-1015667899 HOT 1
- Regular hang in Running test 'typed_threadsafe_function/typed_threadsafe_function_sum' HOT 1
- Better coverage of node-api in Youtube HOT 13
- Node-API add-on build HOT 4
- Add list of non C language bindings to Node.js doc HOT 10
- Document how to check for memory leaks in addon/default leak. HOT 4
- Electron 21 breaks api compatability with some modules HOT 9
- Get contacts for each of the runtimes supporting Node-API HOT 8
- What's new in the Node-API and node-addon-api world? - 2023 version HOT 20
- Can references be shared between different modules/envs? HOT 3
- Improve score on OpenSSF scorecard HOT 8
- Consider changing the license for examples to MIT HOT 2
- Tracking issues for V8 changes needed HOT 1
- Help with node-sqlite3 performance HOT 3
- What's new in the Node-API and node-addon-api world? - 2024 version HOT 3
- Discuss reverting nogc commits HOT 1
- Warn/print message when NAPI_EXPERIMENTAL is used in a build HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abi-stable-node.