Provide some way to annotate exports? about cjs-module-lexer

[guybedford]

We did discuss syntax approaches like this, but it seemed like in most cases the advisable approach was to use ESM wrappers or ESM modules directly for these executions since if Node.js supports this feature it would support ESM anyway.

We can make changes to this processing, but backporting is not necessarily a given at this point so changing things here would result in spotty support for 12 LTS, whereas right now there is comprehensive backwards compat on all Node.js modules semantics paths so it can be reliable.

//cc @GeoffreyBooth @MylesBorins @bmeck @jkrems

[MylesBorins]

Yeah, unfortunately Node.js v12 is now in maintenance so the bar to make changes is going to be pretty hard... especially ones that are not backwards compatible. Not impossible, but very very hard to do.

[GeoffreyBooth]

Would you consider adding some way to annotate the exports that are available in a given file without having to rewrite the JavaScript in the file? A comment with something like //# cjsExports="someName","someOtherName",... would work

If esbuild could output such a comment, wouldn’t it also therefore be able to output a CommonJS module that cjs-module-lexer could successfully statically analyze? That seems like the most straightforward solution, as then nothing would need to change on Node’s side and it would work back to Node 12.

[evanw]

If esbuild could output such a comment, wouldn’t it also therefore be able to output a CommonJS module that cjs-module-lexer could successfully statically analyze?

Yes it could. I addressed this in my original post:

This is undesirable both for minification reasons and because it would require me to support another code path, which is more overhead for me in terms of code complexity and would lead to a bigger test matrix.

It's fine if your answer is "no". The decision is up to you since it's your project. Just thought I'd ask first to see if there was a way to avoid the complexity of having to generate this magic syntax.

[guybedford]

@evanw it might be possible to write out an abbreviated form that basically fools the lexer, to avoid those calls being the full exact defineProperty statements. In a way this might effectively be like what you were asking about.

The lexer doesn't have any concept of execution flow at all, so a non-executed function that looks like it defines exports would be supported.

Here's one way of doing that:

// fake exports to inform lexer
(() => exports.a = exports.b = exports.c = void);

// actual exports definition function
defineExports(exports);

That is then something that is quite close to the syntax you are after that will work all the way back to Node.js 12 as well.

I'd still recommend simply outputting an analyzable form of exports definitions if you can and that would still be preferable. But if you can't then the above can be an option.

[guybedford]

I guess the remaining risk is minifiers removing these unused functions... perhaps there's a way to get around that as well?

That said, the same likely applies to any "syntax approach" even the one asked.

[guybedford]

It seems like #46 or similar will be the approach for now.