Comments (16)
New contributors are absolutely excited about this, few of them sent me emails and shared their happiness. Few of them are picking up work items on their own.
Thank you all the mentors who reviewed PRs with absolute receptiveness, approachability and kindness. Your guidance created a great open source experience to them that they can leverage!
Closing this issue as its purpose is met, having most of the PRs in the codebase; and giving way for #92
from code-and-learn.
If you need issues, especially slightly more challenging ones than the usual initial issues, there are a few PRs that seem really close, but have been abandoned. A couple examples are nodejs/node#21372 and nodejs/node#22315.
from code-and-learn.
are those the correcting the order or
assert
parameters?
@gireeshpunathil That's probably a lot of them, maybe even most of them. And I suspect @BridgeAR will be using those at NodeConf EU, so maybe wait until after NodeConf EU to try to see how many are left?
from code-and-learn.
Suggestions on any other useful and interesting refactoring suggestions are appreciated.
@gireeshpunathil Maybe you can promote v8 name spaces with using v8::
in src
directory. Things like those nodejs/node#23934, nodejs/node#22641
from code-and-learn.
@gireeshpunathil I'll send you a list of tasks later on that are still open from the ones that I created for NodeConf EU but there are only very few left.
In #86 you find a short FAQ for things that are commonly asked. Please feel free to expand that list in case you come among anything new.
I also created #89 as an example how to actually solve the tasks.
As a recommendation: go through the coverage mid next week and create new tasks that people could solve. These have been quite popular and it is nice to have more of these instead of only the super simple ones.
from code-and-learn.
@gireeshpunathil @BridgeAR Thanks for this. By the way, I thought we can also tackle this issue: nodejs/node#22492, in the meet up. It already have list of code blocks, which might need test cases. This in fact, gives the folks an idea to navigate around the codebase and see if a test case is present or not. If not add them (certain things might not be easy). Thoughts? 🤔
I guess this a win-win situation too.
from code-and-learn.
Code & Learn review mode: ON
from code-and-learn.
replace instances of typeof 'x' === 'y' constructs in tests with util.isY(x) constructs [ ~600 instances spread across ~200 test files ]
All the relevant util.is*()
funcitons are deprecated. I don't think we should be using them in test code. I prefer typeof
checks myself. Is there something I'm missing?
from code-and-learn.
I have some leftover tasks from the Vancouver Code & Learn. It's also possible that there will be some leftover after the NodeConf EU Code & Learn. Do you have an idea how many attendees you expect?
from code-and-learn.
If you want to help out ChakraCore, there are tests where they float patches to make them pass with ChakraCore because the error message text is different than provided by V8. In my opinion, we should not rely on error message text that originates from the JS engine as it can change any time we update the engine to a new version. So, a good task might be removing the message text checks and replacing with a simple check that something is a RangeError
or TypeError
or whatever, or else changing them to regular expression or String.prototype.includes()
checks that are unlikely to break.
You'll have to either get the list of tests where this is relevant from @nodejs/node-chakracore or else maybe look at their repo to figure out which tests are modified.
from code-and-learn.
@Trott - thanks, I did not check that util.is*
are deprecated, realized now. So will skip that.
leftover tasks from the Vancouver Code & Learn
are those the correcting the order or assert
parameters? or something else? please let me know, so I will dig those out and see how many are there.
leftover after the NodeConf EU Code & Learn
sure, I will check with @BridgeAR to see if there are TODO items from those, after that event.
Chakaracore - thanks for the suggestion, I will review that and see if we can include that as well.
count of attendees - at this point I have no idea, will get a clear picture in a week's time.
thanks once again!
from code-and-learn.
thanks @ZYSzys ! makes sense, will do! thanks.
from code-and-learn.
given the RSVP count has reached 65, I am thinking of
test: convert anonymous closure functions into arrow functions
to be used as fillers, in case of scarcity.
/cc @Trott to see if this is indeed a good candidate and has no side effects. (IIRC we used it in the past, but don't remember when)
from code-and-learn.
thanks @BridgeAR - that will be really helpful! #89 looks really impressive, agree that it is a real win-win in terms of satisfaction and quality.
from code-and-learn.
@antsmartian - thanks for this insight! definitely looks promising. I will go through it in detail to figure out how to extract PRs from that.
from code-and-learn.
Code & Learn BLR about to start in one hour from now. 50 participants in the room to be on-boarded . Request @nodejs/collaborators to support this with reviews and hand-holding. thanks!
from code-and-learn.
Related Issues (20)
- Code & Learn Saint Petersburg 2020 HOT 2
- Next events? HOT 10
- Mentors for Code-and-Learn @ NodeConf EU (Nov 5) HOT 8
- Scope of Code + Learn for JS Interactive 2018 HOT 8
- Code + Learn Copy for the JS Interactive Website HOT 7
- Mentors for Code + Learn @ Node+JS Interactive 2018 HOT 36
- COSCon'18 (China Open Source Conf) wants to hold a Code + Learn Workshop HOT 55
- Common questions at C&L events HOT 7
- Mentors for Code + Learn @ NodeConf Colombia 2019 HOT 14
- Example coverage task HOT 1
- Mentors for Code-and-Learn @ Seattle (Dec 18) HOT 7
- JSConf Budapest 2019 would like to hold a Code & Learn Workshop HOT 11
- Code And Learn at NodeFest 2018 HOT 4
- CFP: Code + Learn @ JSConf.Asia (Singapore) 2019-06-[14|15|16] HOT 5
- Code And Learn At Beijing April 28th HOT 7
- Code & Learn Saint Petersburg 2019 HOT 9
- Bangalore, May 25th HOT 4
- Node.js Code + Learn at COSCon'19 (China Open Source Conf) HOT 14
- Code & Learn Moscow 2019 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from code-and-learn.