GithubHelp home page GithubHelp logo

Comments (4)

kylemh avatar kylemh commented on May 14, 2024

Hey @arcanis

I think fixing this introduced an issue that's worth resolving. If have the packageManager set, but then run a prepare command with a specific version listed, the value is silently ignored and the packageManager value is adhered to. I think it'd be better for the command to fail with a helpful error or at least provide a logging statement to be less silent about the mistake.

from corepack.

kherock avatar kherock commented on May 14, 2024

@kylemh I don't think this fix has been released yet, unless you have a configuration where you're running corepack from source. Keep in mind that, when defined, packageManager is always adhered to when using corepack yarn, corepack pnpm, etc. To change the package manager version that a project uses, I think you're expected to edit package.json and commit the update.

from corepack.

kherock avatar kherock commented on May 14, 2024

The docs for corepack <binary name>[@<version>] [... args] kind of dances around this fact:

Note that those commands still check whether the local project is configured for the given package manager (ie you won't be able to run corepack yarn install on a project where the packageManager field references pnpm).

from corepack.

kylemh avatar kylemh commented on May 14, 2024

I am installing in CI and using it from source because I'm on Node 14.

What you're saying is totally fair, and I gathered as much... but only after a lot of investigation. There's nothing wrong with the logic, but the CLI logging offers no notice. I guess I'm suggesting that the config "winner" gets an announced in the output of a ran command.

This isn't a question about docs either. I didn't go to corepack docs because I had no CLI errors or logging which indicated implicit behavior was intercepting my explicit command.

from corepack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.