Comments (5)
Question: Do we want to support legacy APIs?
test-http-set-cookies.js
uses a currently not documented way to set headers (note the nested array instead of a flat object):
res.writeHead(200, [['set-cookie', 'A'],
['set-cookie', 'B'],
['content-type', 'text/plain']]);
I'm in favor of just supporting objects. However I remember somehow from this morning that the goal is to support as much of the old behaviour as possible. What do you think @nodejs/http2 ?
from http2.
@robertkowalski I'd focus on documented behavior.
from http2.
For now, definitely focus on documented behavior. We can revisit this once we have that done and working.
from http2.
The compatibility layer in #47 tries to stay true to the documented APIs, for headers on the request and response. Cookies are not yet supported. I don't think it's prohibitively difficult but would rather leave it for a separate PR.
FWIW, core currently uses an Object for headers and trailers. That could be changed to using a Map or linked list.
from http2.
I think we can close this now.
from http2.
Related Issues (20)
- Performance Regression: 100% CPU Usage & Memory Leak HOT 2
- Rebasing from nodejs/master HOT 1
- QUIC HOT 3
- Failing to "make" after update HOT 2
- compat: stream:error -> [res|res]:error broadcasting HOT 4
- Preparing for the PR against master HOT 7
- Race condition in stream.on('end') HOT 3
- Not working will unix sockets HOT 2
- Node.js http/2 performance benchmarks HOT 8
- Error in socketOnTimeout HOT 3
- Updating from nodejs/master one more time... HOT 1
- Usability issue with respondWithFile HOT 2
- Fail to understand how I should handle connection failures from a client. HOT 3
- TODO: implement range support for respondWithFile/responseWithFD HOT 1
- We've landed in nodejs/node master HOT 2
- Could we name module to http2.0? HOT 8
- http2 client: fallback to HTTP/1.1 ? HOT 1
- Support for Cache-Digest (Server Push optimization) HOT 10
- Feature request : Express support. HOT 1
- How to detect if client does not support http/2 ? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from http2.