GithubHelp home page GithubHelp logo

Comments (7)

robpvn avatar robpvn commented on June 3, 2024

I don't like those hacks, but upon thinking a bit more about it I realise that Leaflet has the leaflet-oldie CSS class for this kind of thing, so it should work if we implement that. (A CSS selector named .leaflet-oldie .leaflet-control-minimap-toggle-display That would mean making Leaflet 0.7.0 our minimum required version, which shouldn't be so bad considering it's over a year old and rock stable. (And we'd bump our version to 3.0, hurray!)

But I don't have any IE8 to test with, can you help in that department?

from leaflet-minimap.

robpvn avatar robpvn commented on June 3, 2024

I created a branch for new IE8 support, but it needs some testing. I think it should work fine, and the CSS works correctly when I alter it in Firebug, but someone needs to test it against a real IE8 to make sure it works.

from leaflet-minimap.

seyfro avatar seyfro commented on June 3, 2024

using leaflet-oldie is better than that dirty hack, good point. Just tested it successfully with IE8. BTW: with IE9 the svg image is used, but the rotation when clicking on it does not work.

from leaflet-minimap.

robpvn avatar robpvn commented on June 3, 2024

I added the space like you suggested in the commit comment, is it all good now?

from leaflet-minimap.

seyfro avatar seyfro commented on June 3, 2024

yes, with spaces PNG is shown in IE8

from leaflet-minimap.

robpvn avatar robpvn commented on June 3, 2024

OK, with the new release 2.1.0 we should have the best of both worlds, SVG for modern browsers and PNG for crotchety old fossils like IE8!

from leaflet-minimap.

seyfro avatar seyfro commented on June 3, 2024

great, thanks!

from leaflet-minimap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.