GithubHelp home page GithubHelp logo

Comments (9)

Norserium avatar Norserium commented on May 30, 2024

@trouba, it's strange. Could you provide the screenshot of current body styles in the developer tools?

from react-indiana-drag-scroll.

trouba avatar trouba commented on May 30, 2024

@Norserium Here it is:

Screenshot 2021-04-27 at 20 47 47

from react-indiana-drag-scroll.

Norserium avatar Norserium commented on May 30, 2024

And what's problem? You can redefine the cursor to cursor: auto in your class.

from react-indiana-drag-scroll.

trouba avatar trouba commented on May 30, 2024

The problem is I'm using the library on a canvas element in a react component. I don't want the body to have a grab cursor, only the element I'm working with.

I tried to remove the indiana-dragging class from the body (in onStartScroll) but it falls back to auto, and takes priority over the canvas cursor while dragging.

I could probably find a way to override this but I would prefer not to:

  • have to remove a class from the body
  • have to set the cursor on the body manually each time the dragging state changes
  • have to add css to the body since i'm using this in an isolated component

The best way for this would be to have an option to remove this class if it's only purpose is to add cursor: grab

I could open a PR if you'd like

from react-indiana-drag-scroll.

Norserium avatar Norserium commented on May 30, 2024

I still don't get, why cursor: auto doesn't solve your problem? Child element cursor property should have the bigger priority. The example.

from react-indiana-drag-scroll.

trouba avatar trouba commented on May 30, 2024

@Norserium thanks for your feedback, I made 2 minimal reproduction pens so you can see my issue:

Using .indiana-dragging { cursor: auto; }
https://codepen.io/trouba/pen/yLgmaay
🚫 Cursor switches back to default when dragging, despite the cursor being "grabbing" on the canvas element

Using .indiana-dragging { cursor: grabbing !important; }
https://codepen.io/trouba/pen/bGgXwWy
✅ Cursor is ok

The second one kinda fix my issue but i'd rather not have this class. Maybe I'm missing something here ?

from react-indiana-drag-scroll.

Norserium avatar Norserium commented on May 30, 2024

@trouba, actually, the setting of cursor in body is not the problem. The problem is that child elements of the scroll container has pointer-events: none while dragging, so their cursor property just ignored. You can apply cursor to the whole container to bypass this issue.

There are also questions to your code. For example, why do you access to elements via DOM API and not by refs? Why do you set the style instead of adding class (container--grab, container--grabbing)? In this case autoprefixer will do some job for you.

Perhaps, you did it only to make example faster. If so, there are no questions.

from react-indiana-drag-scroll.

trouba avatar trouba commented on May 30, 2024

@Norserium Thank you , setting the cursor on the scroll container fixes everything

from react-indiana-drag-scroll.

Norserium avatar Norserium commented on May 30, 2024

You are welcome!

from react-indiana-drag-scroll.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.