GithubHelp home page GithubHelp logo

Comments (3)

note35 avatar note35 commented on June 19, 2024

Right, checking args_list and kwargs_list in getCall() will make it work properly. The default return of any getCall(n) will be None.

There is another thing need to consider, there is no class Call in current implementation, I considered to not implement this because of making code simple. All features of spy.call are implemented in Wrapper.py now.

For OOD, you might consider to implement an interface for Wrapper called Call. For sure this is an option.

from sinon.

jonathan-benn avatar jonathan-benn commented on June 19, 2024

Over the long term, I think that creating a new class Call is the right direction

from sinon.

note35 avatar note35 commented on June 19, 2024

Hi,
I have created a gitter here. About creating class Call, we can discuss in there.

By the way, I highly recommend you to fork a new branch and adding your changes in there. With this way, I can also read your commits and code changes. It will make our discussion clear. Later you can rebase your changes into master. 😄

from sinon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.