Comments (12)
It seems that the lookup for forming Allah-related ligatures is also wrong. Using my own names, it is currently something like this:
lookup 10 { # type=4 flag=0x8
sub alef.isol lam.init lam.medi shadda_superscriptalef heh.fina by alef_lam_lam_heh;
sub lam.init lam.medi heh.fina by lam_lam_heh;
}
The first rule is basically eating the shadda and the superscript alef, and the second rule is shortening a lam unnecessarily.
It should instead be something like this:
lookup 10 {
sub lam.init lam.medi shadda_superscriptalef heh.fina by lam_lam_shadda_superscriptalef_heh;
}
from arabic.
/cc @raphlinus
from arabic.
The second rule, the current
sub lam.init lam.medi heh.fina by lam_lam_heh;
could probably be replaced by an alternative, that shortens in second lam only when a shadda is present on it, to get words like "lam, lam, shadda, fatha, heh" (pronounced "lellah" in Persian) right. If we do this, we may need an additional glyph, that has a shorter second lam and shadda on that lam, but no superscript alef.
(This specific comment is really just an idea. It's not high priority. But the original report and my first comment are high priority.)
/cc @behdad
from arabic.
The lookup flag on lookup 10 may also need to change. Currently, it's set to skip marks, and shadda_superscriptalef is defined as a mark, so it seems to be skipping it.
from arabic.
Internal tracker b/21492433
from arabic.
Lowering the priority, since we could do a hotfix for the product. We still need a fix, but it's no as urgent anymore.
from arabic.
Note that there are many ways that this ligature can be applied in wrong contexts, like the word خالله (the last part of it is not the name of God and should not use the ligature) and many more. I suggest to either not apply the ligature by default or (if you think it is worth the effort) use some complex contextual rules like the ones used in Amiri (which might still give false positives, only Arabic was considered).
from arabic.
@khaledhosny: We're trying to be more careful than that. In our current "hotfix" version, we form the ligature for alif-lam-lam-shadda-daggeralif-ha, but not for alif-lam-lam-ha. The word you pasted does form the ligature on my Mac (Geeza Pro, see http://www.org.uib.no/smi/ksv/ArabicFonts.html), but does not on Android.
There's a good chance it'll make it into the next M developer preview. If you could test it then, it would be deeply appreciated.
from arabic.
I think this should be fine. For completeness, you probably should added a فلله ligature (that is feh-alif-lam-lam-shadda-daggeralif-ha).
from arabic.
A related issue found by @behdad: Currently the ligature doesn't have correct MarkLig positioning.
from arabic.
OK, version 1.05 of Naskh is in the repo now. MTI says this issue has been fixed by this drop. @roozbehp can you confirm?
from arabic.
confirmed it is fixed.
from arabic.
Related Issues (20)
- Noto Sans Arabic v2.011: regression with RTL Kerning HOT 3
- Noto Sans Arabic v2.011: numerals on subtending marks are too light in weight HOT 2
- Noto Sans Arabic v2.011: inconsistent Gaf (گ) top line
- Wrong display of U+FB96“ﮖ”(≈<isolated>U+06B3)
- Noto Sans Arabic v2.011: regression with Arabic number spacing HOT 1
- Noto Sans Arabic v2.011: FontBakery QA FAIL: OS/2.usWinAscent value should be equal or greater than 1431 HOT 5
- Does Noto Sans Arabic support English? HOT 2
- Interpolation problems in `NotoNaskhArabic[wght].ttf`
- Allah does not ligate HOT 10
- Overlap Issue in Noto Sans Arabic HOT 4
- Farsi symbol named "سریاء" HOT 10
- Add support for Belarusian Arabic letters HOT 4
- Incorrect diacritic position for letter jeem when using bullets in InDesign HOT 14
- Noto Naskh Arabic - More Weights? HOT 1
- Overlap with ح and گ HOT 3
- no hinted/ in NotoNaskhArabic HOT 1
- U+FDFB missing diacritics in Noto Sans Arabic HOT 4
- U+FDFA is missing diacritics in Noto Naskh Arabic HOT 9
- NotoNaskhArabic v2.018 ? HOT 2
- Please Kill Noto Sans Arabic and instead use Naksh for everything. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arabic.