Comments (4)
This page is dedicated to it: https://notqmail.z0.is/patch/
For now, it is possible to send me a list of commits/branch/ref and a list of patches to test. If you prefer it can be integrated somewhere into https://github.com/notqmail/.
I like the idea of applying patches to netqmail versions. Then we can see when a patch break on master.
This would be a decision point:
- merge the patch (by rebasing onto its branch if any or applying one)
- provide an edited patch that can still be applied,
- drop support for this patch (maybe it is not required anymore)
from notqmail.
I have created the following netqmail branches, corresponding to a variety of published patches:
- netqmail-badmailfrom-wildcard
- netqmail-badmailfrom-x-relayclient
- netqmail-big-concurrency
- netqmail-big-todo
- netqmail-dns-any-to-cname
- netqmail-dns-oversize
- netqmail-ext-todo
- netqmail-smtp-auth
- netqmail-smtp-tls
- netqmail-smtpd-logging
- netqmail-smtpd-spf
Nearly all of these patches required follow-up work. A comprehensive but incomplete checklist of QA due diligence:
- remove trailing whitespace.
- add any new files to FILES.
** merge or remove any spurious files. - if necessary, add any new files to hier.c/install-big.c doc/
- restore Makefile to alphabetical order.
- sync the Makefile shar target with FILES.
- add any new targets to TARGETS.
- remove any ifdef/define lines. The branch contains the feature.
- verify Makefile includes any new header dependencies in .o targets.
- add any missing entries to CHANGES.
- update or add any missing manpages or other documentation.
- stylistic cleanup: make the code match the existing codebase.
- commit any necessary bugfixes.
I have also created a single (sample) notqmail branch:
This patch is one of three that appears in Gerrit Pape's Debian package, and in this branch I've made a stylistic change and added a minor feature.
In total this permits us to treat all netqmail patches separately, and particularly lets us amend those patches to meet the quality standards of the codebase. Further, it gives us a means of producing features on top of that work while also letting us rebase from netqmail to notqmail. Finally, it allows us to do integration testing between these branches via merging them together.
from notqmail.
I would leave some of these points out:
- CHANGES file: this is external work, so no need to document it there
- shar target: we want to kill it, so why bother, it only makes the diff larger
- stylistic/whitespace cleanup: again, this is external work, this would only be necessary if this is going to be merged into notqmail
from notqmail.
Wonderful. I’ve linked to this from https://github.com/notqmail/notqmail/wiki/Patches
from notqmail.
Related Issues (20)
- *BSD blocklist support HOT 4
- Solaris make does not support "make -C"
- when we broke the TLS patch, we didn't notice immediately HOT 7
- Specify public key for verifying signatures for downloaded tarball releases
- "qmail" package installation destroys Debian systems HOT 2
- Rethink about group qmail ownership
- Upgrade from qmail to notqmail HOT 6
- SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) + SCRAM-SHA-512(-PLUS) + SCRAM-SHA3-512(-PLUS) supports HOT 3
- No `stralloc_free` and not freeing memory
- Create a security policy HOT 3
- Supports for BDAT extension? HOT 2
- systemd file missing HOT 7
- missing qmail-remote leads to immediate bounce of a mail
- tcpto.c is not Y2038 clean
- need reliable multi-platform builds HOT 2
- anything to do about SMTP smuggling? HOT 5
- TLS patch updated HOT 12
- suggest options for dealing with Google & Yahoo's latest? HOT 3
- "TOCTOU" in instchown.c HOT 1
- switch from hier.c to ezmlm-idx-style installer.c HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notqmail.