GithubHelp home page GithubHelp logo

Comments (8)

tvanriper avatar tvanriper commented on May 20, 2024 1

Yeah, I noticed that the polyfill created breaking changes between 0.2.x and 0.3.x, which is a tad frustrating, as it prevents you from easily providing a 0.5.3 update.

For now, for my project, I've gone to using something else that isn't quite as nice.

from kahi-ui.

tvanriper avatar tvanriper commented on May 20, 2024

Some additional information...

It's complaining that the variable 'time' doesn't exist. Ignoring the existential, it's clearly defined around line 8474, but I wonder if there's some update to JavaScript that doesn't like the syntax you're using there.

from kahi-ui.

tvanriper avatar tvanriper commented on May 20, 2024

Oh no, it's much worse than I thought...

All of your widgets for handling dates and times are impacted by this, likely because you're using that same function everywhere.

from kahi-ui.

tvanriper avatar tvanriper commented on May 20, 2024

Ah, it's the temporal polyfill that has the bug and you've inherited it. Gads. This is going to impact a lot of libraries.

from kahi-ui.

tvanriper avatar tvanriper commented on May 20, 2024

I'll submit a bug-fix to your dependency. Sorry for the trouble, but at least you're now aware of it, heh.

from kahi-ui.

tvanriper avatar tvanriper commented on May 20, 2024

Ah, no maybe you need an update:

js-temporal/temporal-polyfill#92

from kahi-ui.

novacbn avatar novacbn commented on May 20, 2024

Thanks for the report!

I actually ran into this issue while working on the upcoming stylesheet rework. And tested the newer 0.3.0 polyfill release and seemed to fix it in Chrome. But a new issue came up with calendar handling with non-ISO-8601 (or maybe just Gregorian) calendars in FF 96+.

RangeError: Era a (ISO year 2022) was not matched by any era
    completeEraYear calendar.js:1477
    adjustCalendarDate calendar.js:1506
    isoToCalendarDate calendar.js:593
    temporalToCalendarDate calendar.js:836
    dateAdd calendar.js:1922
    dateAdd calendar.js:102
    CalendarDateAdd ecmascript.js:1402
    add plaindate.js:126
    instance DayPicker.stories.svelte:27
    init index.mjs:1778
    DayPicker_stories DayPicker.stories.svelte:2698
    createProxiedComponent svelte-hooks.js:245
    ProxyComponent proxy.js:239
    Proxy<DayPicker.stories> proxy.js:339
    create_fragment RegisterContext.svelte:34
    init index.mjs:1793
    RegisterContext RegisterContext.svelte:142
    createProxiedComponent svelte-hooks.js:245
    ProxyComponent proxy.js:239
    Proxy<RegisterContext> proxy.js:339
    default collect-stories.js:49
    <anonymous> DayPicker.stories.svelte:2714

A workaround seemed to be explicitly only use the ISO-8601 calendar, but then the components wouldn't automatically inherit the user's defaults. So I'm going to have to look into it a bit more.

from kahi-ui.

novacbn avatar novacbn commented on May 20, 2024

Fixed in v0.6.0.

from kahi-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.