novicell / novicell.umbraco.oembed Goto Github PK

Currently various angular functions are used here:
https://github.com/Novicell/Novicell.Umbraco.OEmbed/blob/main/src/Novicell.Umbraco.OEmbed/App_Plugins/Novicell.OEmbed/oembed.js

However in newer versions of Umbraco v8 and v9 we have some static functions available via Utilities, which mostly are identical with the angular functions and just wrapping these:
https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/utilities.js

It noticed a traditional checkbox currently is used here: https://github.com/Novicell/Novicell.Umbraco.OEmbed/blob/main/src/Novicell.Umbraco.OEmbed/App_Plugins/Novicell.OEmbed/oembed.editor.html#L39

It can use <umb-checkbox> or <umb-toggle> component instead. In this case it would probably use a toggle as it is a setting.

In Umbraco core: https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/embed/embed.html#L48

I notice the use of Html.Raw ... could the Html property perhaps return an HtmlString instead,? That way the property can be rendered "straight up".

EDIT: this is not the place for such a comment. Sorry. My mistake! But now it's here - should it stay or should it go?

Originally posted by @jannikanker in #10 (comment)

I noticed these "buttons" using anchor elements, but should Really use <button type="button"> instead to be accessible: https://github.com/Novicell/Novicell.Umbraco.OEmbed/blob/main/src/Novicell.Umbraco.OEmbed/App_Plugins/Novicell.OEmbed/oembed.propertyeditor.html#L9-L14

The same is valid for this button, which then doesn't need prevent-default directive:
https://github.com/Novicell/Novicell.Umbraco.OEmbed/blob/main/src/Novicell.Umbraco.OEmbed/App_Plugins/Novicell.OEmbed/oembed.propertyeditor.html#L19-L21

Example from Umbraco core:
https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/views/prevalueeditors/multivalues.html#L17

• Installation
• How to use in backoffice - config examples
• How to use - html / razor examples
• Auto Discovery - Enabled by setting
• Adding new providers - https://our.umbraco.com/Documentation/Extending/Embedded-Media-Provider/index-v9

Core package is needed for a solution with multiple projects. Otherwice it creates in every project a app_plugin folder that is not really needed

With the new release candidate inserting vimeo url results in error

Method not found: 'System.String Umbraco.Extensions.LocalizedTextServiceExtensions.Localize(Umbraco.Cms.Core.Services.ILocalizedTextService, System.String, System.String,

Add information in the release notes, on the new package being pushed

I noticed the code is using <novicell-oembed-preview /> which will cause issues in newer versions of Angular, mainly with any following sibling elements.
https://github.com/Novicell/Novicell.Umbraco.OEmbed/blob/main/src/Novicell.Umbraco.OEmbed/App_Plugins/Novicell.OEmbed/oembed.editor.html#L24

So it should be similar to web comments using a end-closing tag, e.g. <novicell-oembed-preview></novicell-oembed-preview>.

Actually only a limited set og HTML elements should be self-closed like br, hr, img, input, etc.