GithubHelp home page GithubHelp logo

Custom Endpoint ignored about merlin HOT 3 CLOSED

novoda avatar novoda commented on August 15, 2024
Custom Endpoint ignored

from merlin.

Comments (3)

niltsiar avatar niltsiar commented on August 15, 2024 1

This was an old issue which is already solved. The problem is a misleading message from HostPinger

When MerlinService is created a local HostPinger variable is created with default values. When onServiceConnected from MerlinServiceBinder is called it takes care of setting the hostname to the MerlinService instance if it has been given to MerlinBuilder. This setHostname takes care of creating a new HostPinger instance with the customEndPoint if it has been set or with the default one.

Here you can find the log with an entry in HostPinger::withCustomEndPointAndValidation

05-18 12:40:27.975 16342-16342/com.novoda.merlin.demo D/Merlin: Host address not set, using Merlin default: http://connectivitycheck.android.com/generate_204
05-18 12:40:28.005 16342-16342/com.novoda.merlin.demo W/khrn_client: init_window num_buffers 3 min undequeued buffers 1 type 1
05-18 12:40:28.005 16342-16342/com.novoda.merlin.demo W/khrn_client: init_window window 0x4f425148, 480x800 hintTransform 0x0
05-18 12:40:28.025 16342-16342/com.novoda.merlin.demo D/Merlin: onServiceConnected
05-18 12:40:28.025 16342-16342/com.novoda.merlin.demo D/Merlin: onBind
05-18 12:40:28.025 16342-16342/com.novoda.merlin.demo D/Merlin: Host address set, using custom endpoint: http://www.google.com`

from merlin.

niltsiar avatar niltsiar commented on August 15, 2024

My bad. I've been testing it a bit more and I wasn't entirely right. The first ping is done as you said with the default endpoint while the following pings use the HostPinger with the custom endpoint.

from merlin.

Mecharyry avatar Mecharyry commented on August 15, 2024

This has been completed in #121 and will be released as part of v1.0.0.

from merlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.