Comments (12)
do we want to add another dependency to this library? Would we be better off renaming Log
to MerlinLog
?
from merlin.
Gradle is clever enough that adding an internal dependency to NoTils is fine.
from merlin.
I don't want to pull in all those Notils methods though 😖
from merlin.
Why not, what is the downside?
from merlin.
forcing libraries in libraries is not cool, it just adds more than what it's supposed. i.e. If I want to use Merlin it is because it does 1 thing and it works well, but I'm forced to use NoTils just because Merlin wants to log using the SimpleLog. What if I'm not gonna use anything in NoTils? I'd just have it there for a simple log, doesn't make much sense
from merlin.
The idea is nobody knows you are using NoTils. I don't think your argument is valid, your saying no library can never use any help (another library) from anywhere.
We're already using keviswiki's HTTP client, what if we wanted to use Guava, or the Support Librarys or ViewPagerIndicator or Gson. Are you saying you'd want to roll your own json parser in every library? :-)
from merlin.
Except you'll end up having to exclude notils
if you start to run out of methods!
In this case we would only use the SimpleLog
. I'm also planning to remove the HttpRequest library
from merlin.
I can see what you're thinking its kind of a pre-optimisation tho. I
wouldn't do that extra work myself
On 12 Jul 2014 17:55, "Adam Brown" [email protected] wrote:
Except you'll end up having to exclude notils if you start to run out of
methods!
In this case we would only use the SimpleLog. I'm also planning to remove
the HttpRequest library—
Reply to this email directly or view it on GitHub
#19 (comment).
from merlin.
@xrigau @ouchadam I am happy to go with your decision, if you choose now - Are we going to include NoTils for logging (& possibly further useage i.e. when we discussed this simple connection test) or will we rename Log to MerinLog
?
from merlin.
another solution would be to simply use Android.Log
without the wrapper class
from merlin.
renaming the MerlinLog
is the simplest fix
from merlin.
👍 for renaming
from merlin.
Related Issues (20)
- Manifest Unresolved Class error on Service HOT 4
- Expand the Merlin demo
- Technical Data Questionnaire Wiki Page HOT 1
- Fatal Exception: java.util.ConcurrentModificationException HOT 5
- The onConnected event fires when first run it HOT 3
- IllegalStateException - You must call canNotify() before calling notify(ConnectivityChangeEvent)
- Android 9.0 Testing HOT 4
- Remove releases folder from repo HOT 1
- Integration tests
- not getting Wifi connected callback HOT 1
- java.lang.NoClassDefFoundError: on API 28 App crashes HOT 5
- Not working in One plus 5t HOT 6
- Mobile connection type enhancements
- Only disconnect is fired when switching from say wifi to mobile connection HOT 6
- Crash HOT 14
- registerConnectable is not able to work after flight mode for a while
- Custom RequestMaker HOT 2
- NPE on ConnectivityCallbacks.notifyMerlinService HOT 1
- How to get internet speed ?
- Migrate from JCenter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from merlin.