Generate properties values on update about efcore.pg

[TPucke]

Would it be appropriate for ValueGeneratedOnAddOrUpdate() to throw a NotImplementedException? I spent a fair amount of time today to discover that this adds nothing.

Using v 2.2.4

[roji]

@TPucke @austindrenski EF Core 3.0.0 actually added support for the upcoming PostgreSQL 12 generated columns, so this will start working (see these docs). We previously had a clear doc note saying that this feature wasn't available on PostgreSQL.

[roji]

From @101shipit on November 22, 2015 1:33

Same for defining a property as ValueGeneratedOnAdd

[roji]

@101ship-it I don't think ValueGeneratedOnAdd is the same as ValueGeneratedOnAddOrUpdate, the former is natively/easily supported in PostgreSQL, e.g. by defining a default value for a column... Or am I missing something?

[roji]

From @101shipit on December 1, 2015 19:57

agreed - they can be done differently - i was just meaning that ValueGeneratedOnAdd also doesn't work yet.

[roji]

Note that this is not the same as #19, which is about xmin as a special case (for concurrency token).

[roji]

This is probably out of scope of an EF Core provider.

Users can still use raw SQL in migrations to set up triggers which can implement ValueGeneratedOnAddOrUpdate.

[austindrenski]

@TPucke At this point, probably not... That would very likely break code in the wild, which wouldn't be great from a patch release.

Emitting a warning sounds more plausible, but I'd need to take another look at the 2.2 architecture. Could you open a new issue with some sample user code showing when/where you expect the warning/exception to happen?