[BUG] Cannot convert undefined or null to object in case of installing a dependency from github about metavuln-calculator

[vigan-abd]

hey @wraithgar @rainabba opened PR #85 with optional chaining (supported from node 14.0.0) and also included test case to keep coverage 100%

[vigan-abd]

hey @wraithgar,re opening issue #80 (comment)

Please see also comment here:
#81 (comment)

[vigan-abd]

I've tried to log output of content of pakumen to see if it has some github link or something but doesn't seem to have:

{
  "name": "bfx-svc-test-helper",
  "modified": "2021-08-11T17:52:16.797Z",
  "_contentLength": 68
}

e.g. on other ones from npm it has this:

{
  "name": "request",
  "dist-tags": {
    "latest": "2.88.2"
  },
  "versions": {
    "0.10.0": {
      "name": "request",
      "version": "0.10.0",
      "directories": {
        "lib": "lib"
      },
      "dist": {
        "tarball": "https://registry.npmjs.org/request/-/request-0.10.0.tgz",
        "shasum": "0910540d9b86c4f90b4c4b44c84025220a1f9d2e",
        "integrity": "sha512-Qn6cLFKm3532h7EOmaUHuONxPtefzpB5StKzR3HE+fkIu+SLHlVWHU8peg4wI9cV9BcX8AZZ7mdss4pcWtFMyA==",
        "signatures": [
          {
            "keyid": "SHA256:jl3bwswu80PjjokCgh0o2w5c2U4LhQAE57gj9cz1kzA",
            "sig": "MEUCIQDtN8dPaaA+tJ+vcIm15O3UCLluoU6Eyx7yaKx2Xl9mwwIgY+J0qIHMdFRNn0GI+YNqfRuQaXgEsMrAzcbJYH1M27M="
          }
        ]
      },
      "engines": [
        "node >=0.1.90"
      ],
      "deprecated": "request has been deprecated, see https://github.com/request/request/issues/3142"
    },
    ...
  },
  "modified": "2023-02-11T04:47:21.625Z",
  "_contentLength": 129997
}

[vigan-abd]

is it ok if we open a PR to make pakumen versions optional?

[wraithgar]

Yes but you'll need to make sure the tests pass and coverage is all there. Folks in the past submitted code-only PRs and bailed on the tests.

[rainabba]

@vigan-abd Mine may get re-opened. It does still need 1 line covered by tests and I was looking for help/input (preferably from someone that knows this codebase). I said I'd give it a go, but it was closed due to a misunderstanding, That test looks like it's going to take some refactoring because that scenario was not anticipated or prepared for and so the code that needs to be tested isn't exposed directly. Feel free to use my branch. If you can help with that test, please feel free. I will give it another go in the next couple hours and will update my original issue and PR as I make any progress.