.inc() "patch" broken when version is prerelease about node-semver

[AsaAyers]

I came here because I have the same problem from the other side.

If I'm on 0.1.2-rc.2 then the next non-prerelease bump should be to 0.1.2.

[isaacs]

Right, so inc() should always go up, and never down. This gets hairy around the cases where you have a patch and a prerelease.

I'd argue that the correct approach would be: inc("1.2.3", "prerelease") === "1.2.4-0" and inc("1.2.3-0", "patch") === "1.2.3"

[AsaAyers]

I think inc("1.2.3", "prerelease") === "1.2.4-0" is usually correct, but there are cases where you'd want the pre-release to bump the major or minor instead. What about inc("1.2.3", "preminor") === "1.3.0-0"? and a premajor to bump to 2.0.0-0?

#65 should address the 2nd issue, but the first seemed more complex, so I wasn't sure how to fix it.

[isaacs]

I think it's simpler to just that a bump to the prerelease will also bump the patch if there isn't already a prerelease.

[AsaAyers]

I'm not totally sure if I'm following. That should be what this PR is doing. I created a quick chart showing in red how semver is working now and in blue how this PR works.

Maybe your objection is to including preminor and premajor? While they might be used less often I think they're needed. Using only semver's inc() it's impossible to reach 1.7.0-0 from 1.6.0: minor goes to 1.7.0 then prerelease goes to 1.7.1-0.

I think "Using only semver's inc()" is important because it gets used by other tools like grunt-release which will bump, commit, push. It defeats the purpose of such tools if I have to manually manipulate the version when generating a prerelease of a minor version.

[eddiemonge]

I believe this is now fixed with the introduction of prepatch, preminor, and premajor.

[isaacs]

Fixed on master.