@nx/esbuild:esbuild with thirdParty: false fails filtering pnpm lock-file correctly in 19.x by not removing overrides about nx

[wewelll]

I upgraded to NX 19.2.0 and still have this issue.

[atsjo]

Since this is blocking me from deploying my firebase functions, unless downgrading to nx 18.3.4 or 19.0.0-beta.6, I worked out a fix using a firebase predeploy script for filtering the lock file. I have verified this is working with both pnpm v8 and v9 in nx 19.2.3.

I added a script to functions predeploy in firebase.json, running this (last param is path to my firebase build):

node tools/filter-overrides.mjs dist/apps/firebase

with tools/filter-overrides.mjs containing:

import fs from 'fs';
const pnpm_lock_file = `${process.argv[2]}/pnpm-lock.yaml`;
const content = fs.readFileSync(pnpm_lock_file, 'utf-8');
const newContent = content.replace(/\noverrides:\n[\s\S]*?\n\n/, '\n');
if (newContent !== content) fs.writeFileSync(pnpm_lock_file, newContent, 'utf-8');

I would really prefer this being fixed in nx, but if others have the same problem as me, this is a possible workaround, allowing you to also upgrade to pnpm v9.

[wewelll]

@Coly010 Is there is any initiative from the NX team to go forward with a fix ?

Like @atsjo This is completely blocking me from upgrading to NX 19, so I'm stuck on the version 18.

[atsjo]

The fix should be easy, as the info seems informational, and should just be removed (as it was previously)....

[atsjo]

A related/similar problem is reported in #26884