Cannot specify more than one dark image in get_fastccd_images about csxtools

[stuartcampbell]

@licode Can you have a look into this ?

[licode]

sure, I am on this.

[licode]

I think this should work

slicerator = get_fastccd_images(db[old_scan_no], (db[old_scan_no-1,old_scan_no+1]))

(db[old_scan_no-1,old_scan_no+1], None, None) is not 1d tuple.

[mpmdean]

Since the notebook server is down, I can't check, but from inspecting the code isn't the problem that the code assumes that the first element of the tuple is a header object?

When called in either of our examples it tried to access {1st element of tuple}.table()

db[old_scan_no-1,old_scan_no+1] returns a list and the code fails because it tries to access the .table() method on this list?

[licode]

yep. This is exactly what error complains about.

AttributeError: 'list' object has no attribute 'db'

[mpmdean]

I think we're in agreement. The code was changed from using the get_table function imported at the start of the module to access the same functionality via the .table() attribute of the input object.

Maybe there are some speed or other reasons for this? If not, my instinct would be to put it back as it was?

[licode]

This is the feature provided in new databroker. We will use header.db.get_images, header.db.get_table, instead of importing at the beginning. The reason is we will have multiple db later, i.e., different db links to different mongo back end. hdr.db provides an easy way to sort out this requirements.

Here is the new doc. http://nsls-ii.github.io/databroker/tutorial.html

[mpmdean]

That sounds like a reasonable way to do it. So should the CSX tool fix would be some try: except: ArributeError blocks to handle either a single dark image or multiple dark images? This functionality was previously in the imported function.

[licode]

sounds good. hdr.db.get_images should work with multiple headers, because nothing changed in db.get_images, we just linked it back to hdr. We only need a quick fix in csxtools. I am working a PR on this.

[licode]

This should be fixed on
#61

[ambarb]

Tested
/opt/conda_envs/analysis-2018-2.1)
csxtools: '0.1.13'

tested before debian 7 upgrade to 8 and it still seemed problematic.

tested this week after debian upgrade to 8 on all 3 servers and not this functionality appears to work without issue.