Comments (2)
This is an important feature to me and I'm willing to put in some work to implement this. On April 1, 2020, API Version 2019-04 will be dropped and that will mean that page-based pagination will no longer be available. We'll need to update our apps to use cursor-based pagination by this date.
At a minimum, this lib will need to return the HTTP response headers so that the caller will have access to the Link
headers described in https://help.shopify.com/en/api/guides/paginated-rest-results. I propose that we add a headers
field to the Shopify.Response
struct. Having access to the headers is important for other reasons too, such as having access to the X-Shopify-Shop-Api-Call-Limit
header. This week I hope to submit a pull-request for this.
As a separate task, we can create a more convenient API for pagination. I think the best way to do this would be to implement an Enumerable
that automatically fetches new pages of results as needed. I've had a great experience using this approach in the past. I'd be happy to contribute a pull-request for this but I may not have time until later this month.
from shopify.
Regarding adding :headers
to the Shopify.Response
struct - that would be great. Exactly how I envisioned fixing this issue - just havent had time. A PR would be much appreciated 👍
As a follow up, please feel free to submit an issue + PR for your Enumerable
implementation.
from shopify.
Related Issues (20)
- Is this project dead? HOT 1
- Set timeout for HTTPoison requests HOT 2
- More detailed documentation HOT 4
- Order fulfillment event is using the wrong resource parser HOT 1
- Add tests to validate structs
- Shop info should be dynamically configurable HOT 1
- ScripTags Not Working HOT 1
- cost missing from InventoryItem resource
- Getting resources that don't necessarily match Resources / NestedResource HOT 4
- OAuth flow in test mock adapter seems incomplete HOT 1
- Feature: Multipass support HOT 1
- [PriceRule] Missing field HOT 1
- [Multipass] Clear up API HOT 1
- Add Versioning Support HOT 4
- Order resource is missing endpoints
- Failing travis-ci checks
- How ready is it? All API calls? HOT 1
- Unhandled CaseClauseError from bug in Posion
- Problems With OAuth Flow using Explicit API Version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shopify.