GithubHelp home page GithubHelp logo

Comments (2)

balexand avatar balexand commented on May 27, 2024

This is an important feature to me and I'm willing to put in some work to implement this. On April 1, 2020, API Version 2019-04 will be dropped and that will mean that page-based pagination will no longer be available. We'll need to update our apps to use cursor-based pagination by this date.

At a minimum, this lib will need to return the HTTP response headers so that the caller will have access to the Link headers described in https://help.shopify.com/en/api/guides/paginated-rest-results. I propose that we add a headers field to the Shopify.Response struct. Having access to the headers is important for other reasons too, such as having access to the X-Shopify-Shop-Api-Call-Limit header. This week I hope to submit a pull-request for this.

As a separate task, we can create a more convenient API for pagination. I think the best way to do this would be to implement an Enumerable that automatically fetches new pages of results as needed. I've had a great experience using this approach in the past. I'd be happy to contribute a pull-request for this but I may not have time until later this month.

from shopify.

nsweeting avatar nsweeting commented on May 27, 2024

Regarding adding :headers to the Shopify.Response struct - that would be great. Exactly how I envisioned fixing this issue - just havent had time. A PR would be much appreciated 👍

As a follow up, please feel free to submit an issue + PR for your Enumerable implementation.

from shopify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.