ntalbs / json_parser Goto Github PK

Current implementation adds additional comma at the end of last element of array or object. For example,

[
 1, 
 2, 
 3,  // <--
],  // <--

or

{ 
  a: 1,
  b: 2,   // <--
},   // <--

Current implementation represents object with BTreeMap<String, Json>. If I use Vect<String, Json)>, the implementation of fmt_object will be similar to fmt_array.

peak() and peek_next() calls source.chars().nth(x). Is this idiomatic way to get n-th char in a string?

Collect errors and return instead of panic! for a single error.

How to implement fmt for map or array?

It is supposed to return error instead of panic:

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/scanner.rs:129:27
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

So, it can be used to calculate the position of ^.

I changed peek() and peek_next() to return char instead of Option<char>:
c73ab9f

But it doesn't look correct. Change back, and handle the returned Option<char> correctly, not just use unwrap().

{
  a: 10,
  b: true,
  c: "hello"
}

to

{
  "a": 10,
  "b": true,
  "c": "hello"
}

Instead of making a side effect by adding token to tokens vector, return the token created.

Do not use scanner.tokens directly in main but use tokens returned from Result.

So it can be used to

• display token (for debug)
• calculate exact pos to display ^