Using sinon-mongoose with chai-as-promised - opinion about sinon-mongoose

[gaguirre]

Hi @julianomqs, the tests are fine.

However, I would suggest you to use built-in mongoose static methods instead of a DAO.
This way you will have one file less and your code would become to:

product.model.js

var mongoose = require('mongoose');
mongoose.Promise = require('bluebird');

var ProductSchema = new mongoose.Schema({
  name: String
});

ProductSchema.statics.findAll = function() {
  return this.find().exec();
}

module.exports = mongoose.model('Product', ProductSchema);

product.model.spec.js

var Product = require('../lib/model/product.model');

describe('Product', () => {

  describe('method findAll', () => {
    var ProductMock;

    beforeEach(() => {
      ProductMock = sinon.mock(Product);
    });

    afterEach(() => {
      ProductMock.verify();
      ProductMock.restore();
    });

    it('should resolve a promise with a non-empty object array', () => {
      var expected = [
        {__id: 1, name: 'Product 1'},
        {__id: 2, name: 'Product 2'}
      ];

      ProductMock
        .expects('find')
        .chain('exec')
        .resolves(expected);

      return Product.findAll().should.become(expected);
    });

    it('should reject a promise with an error', () => {
      ProductMock
        .expects('find')
        .chain('exec')
        .rejects('error');

      return Product.findAll().should.be.rejected;
    });
  });

});

Hope it helps!

[julianomqs]

Hi,

Thanks a lot for your help.