Provide a way to ignore a failed assertion about nunit

[manfred-brands]

@maettu-this Can you explain the reasoning for this, i.e. What is the practical use-case?

[maettu-this]

@manfred-brands, sure:

From TestCentric/testcentric-gui#1049:

I catch AssertionException for dealing with instabilities in the test setup, instabilities in communication with physical devices. In case such test fails, it evaluates the reason and error tolerance and then either cancels or rethrows. For handling this, neither Retry nor IsolatedContext sounds like the right thing to do. And Assert.Throws even less, as the test fails only in e.g. 1 out of a thousand times.

More detailed from the origin:

FTDI, Prolific and EFM (i.e. all physical COM ports) occasionally lose data at 1 MBaud and above.
Teensy loopback pair often generate supernumerous data when limited, unlimited works fine.
FTDI often raises framing errors with hardware flow control.

I cannot circumvent or even fix these issues, as they are given 3rd party hardware or its drivers.

#2758 and #3245 indicate other users and use cases face the same issue.

Summarizing more generally phrased:

There are cases where test logic is called, but under certain conditions is accepted to fail.

[maettu-this]

Another use case is related to local TCP/IP and UDP/IP servers. When running tests in parallel, the system may assign the same local port number to multiple servers. Only one will successfully be able to bind the socket to the port, the others will fail and have to retry on another local port. Pseudo code:

int i = 0;
while (true)
{
    try
    {
        Assert.That(server.Start(), Is.True);
        break; // successfully started
    }
    catch (AssertionException)
    {
        if (++i < MaxRetries)
            server.LocalPort = GetAvailablePortFromSystem(); // try again
        else
            throw; // permanent failure
    }
}

This use case I currently work around by explicitly implementing the assertion rather than using Assert.That():

int i = 0;
while (true)
{
    try
    {
        if (!server.Start())
            throw (new AssertionException("Failed starting the server!"));

        break; // successfully started
    }
    catch (AssertionException)
    {
        if (++i < MaxRetries)
            server.LocalPort = GetAvailablePortFromSystem(); // try again
        else
            throw; // permanent failure
    }
}

This change enables migration with minimal impact on the test implementation.

[manfred-brands]

I see that you might have to try something a few times, but I don't see why that needs to throw an exception simply to try again. Exceptions are expensive and should not be used for this case. As Nich Chapsas says: Exceptions should be thrown when something exceptional happens, not for flow control. See https://www.youtube.com/watch?v=a1ye9eGTB98

private void StartServer()
{
    for (int i = 0; i < MaxRetries; i++)
    {
        if (server.Start())
            return;
        server.LocalPort = GetAvailablePortFromSystem(); // try again
    }

    Assert.Fail($"Failed to start server after {MaxRetries} retries.");
}

I know that this was an example, but it would be much better that the GetAvailablePortFromSystem() would be thread safe and not return the same value for different threads.

Alternatively you could use the [Retry(MaxRetries)] on your test so that NUnit will retry your test instead of you having to code it yourselves. This would also fix the "occasional data loss" example.

[maettu-this]

For the GetAvailablePortFromSystem() case it's not that simple: "you can specify 0 for the port number. In this case, the service provider will assign an available port number between 1024 and 65535". I have no control over what .NET does and how it is implemented. And even if changing the implementation to using e.g. TcpConnectionInformation, there is no way to prevent some service or application to open a connection on that very port while the test is running.
As of rearranging the loop as you propose, it's a start but my example is a simplified version of what needs to be done. There is a bunch of other assertions involved, rearranging would require some more redesign.

For the hardware reliablity case I think exceptions are OK to be used, as the issue happens in about 1 out of a thousand times, i.e. indeed is exceptional. Of course I could redesign the test in a way to handle this in a different way, but why making the test implementation less obvious by no longer using Assert.That and reimplement the needed assertions?
Using [Retry(MaxRetries)] is no reasonable option either, as some of these tests take up to an hour. Simply repeating takes too much test time, especially given there only is a limited number of connected devices available for the tests.

These are two concrete examples where the pre 3.10 ability to ignore/reset a failed test result was convenient and pragmatic. Of course there are other ways to implement this, but why make things more complicated if they can be simple? I don't know the details behind #2758 and #3245 but apparently others have been using this simple approach as well.

[manfred-brands]

I looks like the below works for me:

[Test]
public void ResetsPreviousErrors([Values] bool value)
{
    try
    {
        Assert.That(value, Is.True);
    }
    catch (AssertionException)
    {
        NUnit.Framework.Internal.TestExecutionContext.CurrentContext.CurrentResult.AssertionResults.Clear();
    }
}

We might want to add a convenience method like Assert.Reset() or similar.

[stevenaw]

I think the idea of allowing more control over this state or scope could be helpful. There's a few other similar discussions over time where some assumptions about pre-3.10 behaviors didn't align with the Assert.Multiple changes in that release.

#3337 has a bit of background, in particular about past guidance not to rely on thrown exceptions while #4587 outlines another option to "scope" assertions.

@manfred-brands I feel like we've looked at ideas for a Reset() convenience function in the past, though I'm having a hard time finding it. I can't recall if we felt it better to have it reset all failed assertions for a test or just those in a current "multiple scope" in the event that they are nested - or if a decision was made at all!

@nunit/framework-team is this something we should add?

[stevenaw]

Oh! It was #4461

EDIT: Seems the nature of the issue was slightly different than I remember, but perhaps seeking the same motivation of exposing more control over flow within a test containing many assertions

[maettu-this]

NUnit.Framework.Internal.TestExecutionContext.CurrentContext.CurrentResult.AssertionResults.Clear();

Excellent @manfred-brands, this looks very promising! Basic verification looks good, full verification in my test setup I haven't managed to complete today. I should have this done by Tuesday.

Of course a convenience method would nice, rather than having to call such internal method. To me, having embedded systems backgound, Assert.Reset() more sounds like "apply reset and make sure it works". Alternatives:

Assert.ResetResult()
Assert.ResetResults()
TestContext.CurrentResult.Reset()
TestContext.CurrentContext.ResetResult()
TestContext.CurrentContext.ResetResults()
TestContext.CurrentContext.ResetAssertionResult()
TestContext.CurrentContext.ResetAssertionResults()
TestExecutionContext.CurrentResult.Reset()
TestExecutionContext.CurrentContext.ResetResult()
TestExecutionContext.CurrentContext.ResetResults()
TestExecutionContext.CurrentContext.ResetAssertionResult()
TestExecutionContext.CurrentContext.ResetAssertionResults()

I haven't yet fully understood the difference among TestContext and TestExecutionContext. Maybe placing the method into TestContext.Current* is wrong and it should be TestExecutionContext.Current*. If the team decides to accept such convenience method I'm sure you'll find the best matching spot.

My personal favorite is Test*Context.CurrentResult.Reset(), as implementation details like "AssertionResult" or the fact that the result is plural don't need to be exposed to the user. Assert.ResetResult() would be my second bet.

In any case, previously linked #2758 and #3245 should also be happy with what will be concluded here.

[stevenaw]

@maettu-this Thanks for the great naming ideas.

I admit, I'm on the fence myself about adding this. Exposing a formal API to control NUnit state directly like this takes some "guard rails" off, and any new feature always carries a potential to make others more difficult to evolve if they're found to be in conflict with each other.

However, there also seem to have been a few pain points over time that I thought the idea could be a good starting point for discussion. 🙂

[maettu-this]

@manfred-brands, I confirm that I can cover all my use cases with...

NUnit.Framework.Internal.TestExecutionContext.CurrentContext.CurrentResult.AssertionResults.Clear();

...and @stevenaw, myself I can live with using the internals, I have created a TestExecutionContextEx.ResetCurrentResult() to wrap around the NUnit internals.

However, while I fully understand the trade-off for long term maintainability, still, the several issues indicate this is a demand. I think NUnit should come up with a non-internal solution. Providing a public wrapper method should decouple the public API well-enough from the internals, while having the public API will make sure the demand for such functionality is kept covered.

[CharliePoole]

At the time this change was made, we had been telling people for years "Don't rely on catching the exception because NUnit's use of exceptions is considered an internal implementation detail, which may change at any time. When we changed it for a major release, some folks complained, of course. One problem was a third-party runner, which relied on the ability to catch the exceptions. IIRC we added TestExecutionContext.IsolatedContext for use by that runner and similar situations, since TestContext was user-facing while TestExecutionContext was part of our internal implementation. The idea was that anyone using internals should know they are internals and accept the risk.

My 2 cents on this is that behavior where a failing test "changes its mind" and decides it should pass is not something to encourage. Making it hard to do could be considered a feature.

[stevenaw]

Thanks @CharliePoole that's a good point and perspective about tests which may "change their minds".
My thinking had been that any change here, if made, should still be in the internal namespace, however even that I am now feeling a little wary of. I would be fine with not adding any new APIs here as it seems that many of the past cases where this has come up have also all found their own respective resolutions - sometimes by indeed updating the tests to make them more robust.

@manfred-brands I know the suggestion was one originally raised by you here which I'd then run with a bit. What are your thoughts on it all?

@maettu-this Great to hear as well that you've been able to adjust things on your side to make things work independent of any action taken here :)

[maettu-this]

@stevenaw, well, I was able by making use of NUnit internals. It works, but I as previously mentioned I still think this is something that should be publicly available.

@CharliePoole, I do agree that changing the tests is preferred, but in the majority of cases I face it would have made the test logic way more complex than necessary. So I stick with "why make things more complicated if they can be simple..." adding "..and obvious". Tests "changing their mind" enables reusing existing test code even for cases where things occasionally go awry, for known or even good reasons. I think reusing such code is preferred over making things more complex.