Comments (4)
True. Although most colorschemes define these colors our implementation does not handle it correctly.
This should probably be something like
color = get_color(DiffAdd, fg) or get_color(DiffAdd, bg)
do you agree?
from lualine.nvim.
color = get_color(DiffAdd, fg) or get_color(DiffAdd, bg)
I donn't think get_color is returning nil if it was we would already be defaulting to default_colors provided inside signify component. Though I havesn't yet checked what it's returning. If fg
doesn't return nil it wonn't work either.
from lualine.nvim.
I know. Do you have a better solution though? We cannot possibly support all colorschemes. I think we should implement my suggestion and if that doesn't handle all edge cases then the user can configure colors themself
from lualine.nvim.
I know. Do you have a better solution though? We cannot possibly support all colorschemes
I still think providing our defaults is better than trying to get colors from colorcheme when we have no idea what they look like . In one colorscheme I tested the signify components added and modified colors fg completely blended with bg so what I had was a big empty area and after that removed count.
We should just provide a set of colors if users donn't like it they can change it atlest the colors we provide wonn;t produce weird behiviors like this.
from lualine.nvim.
Related Issues (20)
- Disable lualine on terminal HOT 1
- Bug: There was a bug. HOT 1
- Bug: Not detecting branch on files in subdirectories HOT 4
- Feat: Custom refresh rate per component
- Feat: Merging one of the PRs that add support for base16-vim colorschemes HOT 2
- Feat: add `coc_workspace` option to diagnostic sources
- Feat: align to left for component
- Feat: Show some "untracked" marker in the diff component
- Bug: fzf extension shows 'nil' instead of selected element on split pickers
- Bug: when running mosh with neovim and lualine, terminal is broken
- Bug: Two status lines appear when using nvim -p[x] and switching tabs HOT 8
- E539: Illegal character <,> HOT 3
- Feat: Hide the lualine background color when fzf-lua/fzf is up and running
- Bug: (suggestion): remove default filename in command bar when there is one displayed in lualine HOT 1
- Feat: Add harpoon-lualine to Wiki page HOT 1
- Bug: Component conditions not properly evaluation at launch
- Feat: Middle custom options HOT 5
- Bug: User runtime path doesn't have priority on Windows
- Feat: Show tab number by default unless the tab is renamed HOT 1
- Feat: More flexible way to disable lualine or enable extensions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lualine.nvim.