Error with Neotest-go, subtests and skipping them. about neotest-go

[tkrause]

I'm also seeing this but with a very cryptic error about a nil pointer in a coroutine.

Seems to happen with subtests consistently where I have multiple levels of subtests.

          if not tests[testname].file_output[testfile] then
            tests[testname].file_output[testfile] = {}
          end

          if not tests[testname].file_output[testfile][linenumber] then
            tests[testname].file_output[testfile][linenumber] = {}
          end

In that same file, at least keeps it from crashing. But this seems like a bigger issue with parsing subtests.

[fredrikaverpil]

I am also seeing an error around marshal_gotest_output when using nested tests that might be using t.Skip():

   Warn  10:59:47 notify.warn Neotest neotest-go: ...edrik/.local/share/LazyVim/lazy/neotest/lua/nio/init.lua:105: The coroutine failed with this message: 
.../share/LazyVim/lazy/neotest-go/lua/neotest-go/output.lua:82: attempt to index a nil value
stack traceback:
	.../share/LazyVim/lazy/neotest-go/lua/neotest-go/output.lua: in function 'marshal_gotest_output'
	...al/share/LazyVim/lazy/neotest-go/lua/neotest-go/init.lua:214: in function 'results'
	...share/LazyVim/lazy/neotest/lua/neotest/client/runner.lua:132: in function '_run_spec'
	...share/LazyVim/lazy/neotest/lua/neotest/client/runner.lua:89: in function <...share/LazyVim/lazy/neotest/lua/neotest/client/runner.lua:88>

In my case I have a test looking like this:

func TestAddSubTestLevelSkipping(t *testing.T) {
	for _, skip := range []bool{true, false} {
		t.Run("Subtest1", func(t *testing.T) {
			t.Run("Subtest2", func(t *testing.T) {
				if !skip {
					t.Skip("skipping test")
				}
			})
		})
	}
}

It works fine on the commandline:

go test -timeout 30s -v -run ^TestAddSubTestLevelSkipping$ yolo/cmd
=== RUN   TestAddSubTestLevelSkipping
=== RUN   TestAddSubTestLevelSkipping/Subtest1
=== RUN   TestAddSubTestLevelSkipping/Subtest1/Subtest2
=== RUN   TestAddSubTestLevelSkipping/Subtest1#01
=== RUN   TestAddSubTestLevelSkipping/Subtest1#01/Subtest2
    app_test.go:42: skipping test
--- PASS: TestAddSubTestLevelSkipping (0.00s)
    --- PASS: TestAddSubTestLevelSkipping/Subtest1 (0.00s)
        --- PASS: TestAddSubTestLevelSkipping/Subtest1/Subtest2 (0.00s)
    --- PASS: TestAddSubTestLevelSkipping/Subtest1#01 (0.00s)
        --- SKIP: TestAddSubTestLevelSkipping/Subtest1#01/Subtest2 (0.00s)
PASS

What's interesting here is that by removing the ! in front of skip, the test passes without issues in neotest-go:

-				if !skip {
+				if skip {

Could it be that neotest-go doesn't properly parse the /#01/ in the path TestAddSubTestLevelSkipping/Subtest1#01/Subtest2?

Also, note that the second subtest (Subtest2) is also subject to this bug: #52

[fredrikaverpil]

I added a reproducible example here:

• Screenshot, links: https://github.com/fredrikaverpil/go-playground/blob/main/bugs/neotest-go/README.md#crash-in-marshal_gotest_output
• Go test code: https://github.com/fredrikaverpil/go-playground/blob/main/bugs/neotest-go/marshaloutput_test.go

[sergii4]

@MortenGerdes could you please update and check now?

[fredrikaverpil]

I can confirm I no longer get the marshal_gotest_output error I reported here on my end anymore. 🎉

[MortenGerdes]

@sergii4 Seems fixed on my end after your update. I had two places where I ran into the issue and both are now working 🙌

Great work!