Unnecessary setters about fpsci

[jspjutNV]

I assume these setters were created so the Experiment could safely set these values. I'm not sure the Experiment still sets these, or if they're only set up front. I'd prefer to remove these functions and just directly set the variables.

@joohwankimNV , are you okay with this simplification?

[bboudaoud-nv]

To provide a bit more detail, at least setSceneBrightness() is only every called with m_sceneBrightness as its argument, so this is effectively equivalent to m_sceneBrightness = m_sceneBrightness.

[jspjutNV]

Oh wow, so it seems like there was some confusion around setSceneBrightness() to begin with.

Maybe some version of the ReactionExperiment was using this in the past. I think for abstract-fps it's totally safe to remove.

[bboudaoud-nv]

Okay, planning to deal with both of these functions in one commit. Will leave a commented out line indicating where scene brightness was "set" before (even though it was always just re-assigned to identity).

[bboudaoud-nv]

These were removed as of a recent commit, there is still a commented out line at line 688 of App.cpp intended to capture where we had done this previously.