Target Health Bar about fpsci

[jspjutNV]

I like keeping around the health bar and creating an issue to make it track the target as you'd expect.

Adding a config option to allow this kind of health indicator to be enabled or disabled sounds appropriate as well. Default value should be False.

While we're at it, we might want to add a config option to enable target health color shift which can be set to True by default.

[bboudaoud-nv]

I (broadly) agree with this, and could see us offering up 3 options here:

1. The current colored target (maybe w/ customizable colors eventually)
2. A health bar that tracks the target
3. A health bar that is positioned statically somewhere in screen space

I think having 2 flags could manage this (since some may want both the target color shift and health bar). We could also use the lack of a provided position for the health bar as an indicator to tie it to the target. As for color shift, I was debating whether we let the user just specify 2 colors (max/min health) and then let the app interpolate between the two. If the two colors are equal then the target is just constant color.

[jspjutNV]

I don't think a static target health bar makes sense very often. I can think of a few "boss fight" type scenarios in games where they add a health bar in the center top of the screen. Here's an example screenshot of that.

Key to these kinds of scenarios is that the boss often has many targets that are valid and all contribute toward damage to the same health pool. While implementing this style of health bar is easier, I don't know that we need it to be a core feature we maintain like the target color or tracked health bar.

[bboudaoud-nv]

I think we could still support the fixed health bar (boss-style) option, especially since it is trivial once you have the option for positioning it above the target.

Since @jspjutNV posted the image above, do we also want to start another issue (possibly referencing this one) for floating combat text? I know we discussed this at some point, but weren't sure how we wanted to implement it.

[bboudaoud-nv]

Closing this for now as @pknowlesnv's recent commit takes care of the basics. We've also moved floating combat text to it's own issue (Issue #24). The only possible remaining item is adding back in a "boss-style" health bar, but this hasn't been requested up to now. Can create a new issue for this in the future.