GithubHelp home page GithubHelp logo

Comments (3)

bacTlink avatar bacTlink commented on July 28, 2024
  1. misWeight should always be 1 for point lights since they are not hitable.
  2. When bsdfSampleRec.pdf <= 0, the direct light contribution is also not accumulated.

from vk_raytrace.

mklefrancois avatar mklefrancois commented on July 28, 2024

Thanks for the comments, I will have a look.

from vk_raytrace.

mklefrancois avatar mklefrancois commented on July 28, 2024

The punctual lights was a quick addition, but this commit 4b0e78d should hopefully fix it. If eventually there are area lights with glTF, the code should be adapted.

from vk_raytrace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.