Comments (7)
from vk_raytracing_tutorial_khr.
from vk_raytracing_tutorial_khr.
maybe I did not make my question clear
p = 1/PI here represent the pdf of importance sampling pdf (which there is cos_weight_sampling)
line 111
https://github.com/nvpro-samples/vk_raytracing_tutorial_KHR/blob/8d4ba64b1816ef020bebe33298d496b305df2aca/ray_tracing_gltf/shaders/pathtrace.rchit#L111
show the out-going ray sampling strategy, and using cos_weight importance sampling
here the pdf of cos_weight imporance sampling is
and the algorithm in the code chooses outgoing directions
with pdf = cos theta/pi (where cos theta is the dot product in the equation
above).
and here you said
and
so always hadcos(n, out) BRDF(in, out)/PDF(in, out) == 1
.
So if p represent pdf of cos_weight sampling here ,why should not be cosTheta/ Pi?
I worry about that latex may not be rendered if you read it from mail, and thanks to your reply.
from vk_raytracing_tutorial_khr.
and if p = 1/Pi as the pdf of sampling , in hemisphere the integral of p is not 1
from vk_raytracing_tutorial_khr.
Ah, I see! Sorry about that - thank you for following up! Since samplingHemisphere()
is cosine-weighted, this line of code was incorrect -- it should have been const float p = cos_theta / M_PI
. (As a result, you might notice that running the current code under the white furnace test renders a sphere that is too dark.) We'll put in a fix. Thanks!
from vk_raytracing_tutorial_khr.
:)
from vk_raytracing_tutorial_khr.
Fixed in #56 and 80e00ca; closing. Thanks again!
from vk_raytracing_tutorial_khr.
Related Issues (20)
- Error in hello-vulkan during compilation HOT 4
- Why did the QUADRO P620 support raytrace? HOT 2
- ray_tracing_motionblur: Validation error HOT 2
- ray_tracing_ao crashes when Nsight is used HOT 2
- Fix raytrace.rgen in ray_tracing__advance HOT 1
- Incorrect srcStageMask in vkCmdPipelineBarrier in ray_tracing_ao HOT 2
- Second rmiss shader defined too early in the tutorial HOT 1
- add new simple sample showing usage of Ada SER functionality (via new VK NV SER ext) HOT 1
- add new simple sample showing new Ada OMM functionality (via new VK NV OMM ext) HOT 1
- What does Nb mean? HOT 2
- gl_InstanceId and gl_InstanceCustomIndex HOT 5
- VK_BUFFER_USAGE_STORAGE_BUFFER_BIT for vertices and indices buffer HOT 2
- gl_LaunchSizeEXT corresponds to the image size provided when calling traceRayEXT HOT 2
- Could NOT find VulkanSDK (missing: VULKAN_LIB VULKANSDK_SHADERC_LIB) HOT 3
- Runtime error in creating swapchain on Tesla T4
- The tutorial page is blank HOT 2
- Link is broken HOT 4
- issue on win10 when cmake HOT 2
- Framebuffer becomes invalid (ray_tracing_gltf) HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vk_raytracing_tutorial_khr.