Download version / proxy issues about npm-installer

[Mithgol]

Would it be enough to upgrade the required version of out download dependency?

What would be that changes to the latest (i.e. proxy-related) section of our README?

P. S.   Sorry for the late reply, I've been a bit busy.

[Mithgol]

Starting from the version [email protected] (from d926efd onwards) this package uses [email protected] as its dependency.

P. S.   Sorry for the late upgrade, I've been a bit busy.

P. P. S.   We still need some changes in README before it becomes okay to close this issue.

[amaslenn]

Hi @Mithgol!
I have an issue with proxy. I use v0.20.2 on Windows and macOS. If I set both http_proxy and https_proxy (both correct and deffer by protocol and port, other apps and npm itself works fine with them), post install scripts fails with tunneling socket could not be established, cause=socket hang up. With https_proxy='' script works fine.

[Mithgol]

Hi @amaslenn!

Does kevva/download#64 seem like the issue that you've encountered?

[amaslenn]

@Mithgol yes, it looks similar. Except exact cause: I get hang up, other reasons are mentioned in the issue. But root cause could be the same.

[Mithgol]

@amaslenn I am inclined to decide to wait until the cause is fixed by the authors of download unless you suggest a good enough replacement for download (where “good enough” means “won't introduce more problems than it solves”).

[amaslenn]

@Mithgol sounds good. You can ping me to verify fix.

[Mithgol]

Two hours ago I merged @nurishi's b9737cf.

We are now using download@^5.0.3, which uses caw@^2.0.0, which uses get-proxy@^1.0.1, which has some code to ensure that http_proxy and https_proxy both work.

Does it really help? Please try [email protected] or [email protected] to verify the fix.

[amaslenn]

I'm afraid I don't have required machine configuration now to verify it.
Let's assume it works.

[Mithgol]

Okay, let's do it.

I am closing this issue (considering it fixed).

If a proxy-related issue surfaces in the future, it should be (by default) treated as a separate issue (until proven otherwise) and opened as a new issue on GitHub.