Don't generate /dist/typescript about actions-netlify

[peaceiris]

How about ncc build ./src/main.ts -o dist?

[South-Paw]

@nwtgck even though they don't use Typescript, they compile their package to a CJS format using webpack/babel and something is either wrong with that compile or it needs to go to more formats - I'm not very well versed in package formats (CJS/UMD etc) so I can't offer much more than blaming the netlify package 😄

Even so I would say it is certainly their packages issue - there is nothing wrong with your package here.

I have another Github action (its not really useful, just a playground action really) but I also checked how it built and I don't get the weird dist/typescript folder when I build using ncc either

[peaceiris]

You may not need to run tsc before ncc build in your release process.

[nwtgck]

@peaceiris

Thanks!

I ran as follows, but "./dist/typescript" was still generated.

rm -r dist
# NOTE: I don't run "npm run build" not to run `tsc`
npm run format && npm run lint && npm run pack && npm test

[nwtgck]

Thanks! I removed ./dist and ran the ./node_modules/.bin/ncc build ./src/main.ts -o dist, but still generated.

[nwtgck]

note for me

Here are the whole diffs between the template and current files: 0340e02...825cfca. It seems there is no difference related to some configurations.

[South-Paw]

Somehow it's related to the netlify import... might be something to do with how they export it 🤔

Removing the netlify import and then running ncc for me;

If I bring back the netlify import, it builds dist/typescript again.

[nwtgck]

@South-Paw Thank you very much for the information! According your investigation, import NetlifyAPI from 'netlify' creates /dist/typescript.

[South-Paw]

@nwtgck 👍

It might be because of how they build/distribute their package... might be best to raise and issue over there to see if you can get anywhere.

[nwtgck]

@South-Paw Thanks. Maybe I should post the issue. But, netlify/js-client doesn't use TypeScript at all, written in JavaScript. I'd like to investigate the reason more.

[nwtgck]

@South-Paw Thanks.

I'm not very well versed in package formats (CJS/UMD etc)

Me too.

Your are the finder of import "netlify" thing. I think it is better to create the issue by you because you can be a contributor!

[nwtgck]

#178 solves this issue! Thanks @rajington!
tsconfig.json: https://github.com/nwtgck/actions-netlify/pull/178/files#diff-e5e546dd2eb0351f813d63d1b39dbc48