Comments (3)
I have a test case that started failing in the last few days. There is a similar one that succeeds. The one that fails serves an html file (with http.ServeFile()
), and the one that succeeds serves a binary file the same way. The code is exactly the same, only the file name is different.
In case of the html file, the headers are:
HTTP/1.1 200 OK
Accept-Ranges: bytes
Content-Type: text/html; charset=utf-8
Date: Sun, 18 Sep 2016 17:52:39 GMT
Last-Modified: Sun, 14 Jun 2015 14:24:51 GMT
Set-Cookie: _SESSION=; Path=/; Expires=Mon, 18 Sep 2017 17:52:39 GMT; HttpOnly
Vary: Accept-Encoding
But in case of the binary file, the headers are different:
HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: application/octet-stream
Date: Sun, 18 Sep 2016 17:52:39 GMT
Set-Cookie: _SESSION=; Path=/; Expires=Mon, 18 Sep 2017 17:52:39 GMT; HttpOnly
Vary: Accept-Encoding
I use http.Client
in both cases to retrive the results. In the failing case, ioutil.ReadAll()
returns an io.ErrUnexpectedEOF
error, but the returned data matches exactly the data on the disk. If I disable the gzip encoding in the failing case, by sending Accept-Encoding: identity
, the test succeeds. In both cases, the response's Uncompressed field is true.
from gziphandler.
I did a bisect. My tests are green with 44afc59. The next commit d3d7d67 makes a lot of my tests fail, and then at cdd181b I can reproduce the exact same failure.
from gziphandler.
Thanks for the fix @jprobinson 🎉
from gziphandler.
Related Issues (20)
- Static files from ServeFile HOT 2
- Incorrect check for short write
- $maccon
- State of the package? HOT 1
- If not handleContenttype it buffers entire content
- make acceptsGzip public HOT 4
- Whitelist by mime type HOT 7
- Handling HEAD requests
- Do not set Content-Length on OPTIONS requests
- The NYTimes GitHub org will be renamed to nytimes HOT 4
- go mod depends on 1.12 HOT 11
- Range-Requests aren't properly handled
- Should Content-Length be set on gzipped responses? HOT 1
- Align Go package casing with VCS URL casing HOT 1
- Accept func(w http.ResponseWriter, r *http.Request) literals
- How to force flushing from the wrapped handler? HOT 4
- Show the error of gw.Close()
- Vary: Accept-encoding header is duplicated if inner handler sets it HOT 2
- Swappable gzip implementation? HOT 7
- "identity" Content-Encoding should also be compressed HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gziphandler.