GithubHelp home page GithubHelp logo

Use functional options about gziphandler HOT 3 CLOSED

adammck avatar adammck commented on July 30, 2024 1
Use functional options

from gziphandler.

Comments (3)

dolmen avatar dolmen commented on July 30, 2024 1

If this is fixed, it might be time for close of this issue, isn't it?
I'm discovering this project and most open issues seem to be in fact done. Discovering that after the read of a long discussion is unexpected.

from gziphandler.

jprobinson avatar jprobinson commented on July 30, 2024

After playing around with more and more go-kit, I've been leaning towards the latter lately.

from gziphandler.

tmthrgd avatar tmthrgd commented on July 30, 2024

This was fixed with the merging of #51.


The main difference was that the options take the form:

wrap, _ := gz.GzipHandlerWithOpts(gz.CompressionLevel(1), gz.MinSize(1024))
wrap(myHandler)

instead of:

gz.New(myHandler, gz.CompressionLevel(1), gz.MinSize(1024))

Either this should be closed or considered a request to add the New function described above.

from gziphandler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.