Comments (9)
Thats quite a laundry list and rather than hold #47 up waiting on all of that, I would suggest that those changes be made incrementally. Each of those are good changes but they can easily stand on their own as individual pull requests.
Some of the changes in #47 would definitely be unnecessary if all of what you are proposing was already said and done, but given that #47 is ready to go and represents a step in the right direction, I don't necessarily see a convincing reason to wait an undetermined amount of time on the above. And again I think some of those items would be better suited as individual PRs.
from pourover.
I agree, but if these changes were to be merged in they would undo some of the work that's currently done. I'd rather not create the git history, only to undo it in a week or so.
I see 2 PR's for these changes. The first will complete points one through four. The reasoning is that as I'm migrating the tests over to mocha, pourover.js
itself isn't ready for node usage out of the box. That being said I'll be updating pourover.js
to be out of the box ready for bower, component, node, and the web. Once the tests and pourover.js
are passing we can cute a new release, considering it will do exactly what our original task was of adding bower, component and node support. The second PR I will improve documentation, point five.
All these PRs won't break anything currently using pourover, it will just be a major version bump to 1.1.0
from the first PR and then a minor version bump to 1.1.1
. Note: The versioning is based off of semver.
from pourover.
@TomNeyland I'm going to rebase this onto your fork/branch and send you the PR
from pourover.
@TomNeyland I have completed points 1, 2, 3 & 4 and have sent you a PR: TomNeyland#4. Unless we'd like these changes to not be apart of your PR.
Notes:
- All tests are passing, I've changed the release number to
1.1.0
as we added "functionality in a backwards-compatible manner". - Publish to Travis will need to be taken care of by the maintainers of NYTimes.
- Publish to NPM will also need to be taken care of by the maintainers of NYTimes.
- Point 5 will be done in a separate PR and along with this I will add the Travis Badges.
from pourover.
Am I right in that the recommendations listed here are present in some form in @hhsnopek's version? If so, I'll close the Issue with a pointer over to that repo for people who need these additions.
from pourover.
@tiffehr Yeah, be sure to checkout my community version of pourover which close many of the open issues in this repo. Also I've opened a gitter channel and hold bower/npm ownership atm. It would be awesome if a lot of the upstream changes from my fork could get merged in. Lemme know what you think!
from pourover.
Considering that the community edition has these changes, and I'll be mirroring the changes from this repo with other changes. You could close #47
from pourover.
Do you want to preserve this history/checklist for your own repo in some fashion?
from pourover.
I have issues open currently for them, this list was a reference to what was occurring in my fork :)
from pourover.
Related Issues (20)
- Add event for pre-query/filter change HOT 1
- add package.json for npm HOT 5
- Basic Pourover example broken HOT 2
- PourOver View is broken HOT 1
- Suggestion: Simple API doc HOT 2
- Sort `attr` property has no effect. HOT 2
- DB on top of PourOver HOT 1
- Cant delete the items in the collection HOT 1
- Uncaught TypeError: undefined is not a function HOT 1
- Lodash v3.7.0 (latest) Breaks Pourover HOT 3
- request for PourOver website to load the pourover.js file HOT 3
- Distributed PourOver HOT 9
- Website's link to "tamper" 404s HOT 1
- Nested dictionaries inside collections HOT 1
- Aggregation with pourover HOT 6
- Community collaboration suggestions from @hhsnopek HOT 4
- chain sorting, via @ outofculture
- Get gh-pages/Jekyll generating a proper wrapper with PourOver & collection ready in devtools console
- [question] Any thoughts of node? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pourover.