GithubHelp home page GithubHelp logo

Comments (6)

laurentkempe avatar laurentkempe commented on June 5, 2024 1

👍🏼 Works like a charm @o2sh Thanks for the lightning-fast fix 👏🏼

from onefetch.

spenserblack avatar spenserblack commented on June 5, 2024

Just checked and confirmed they don't match. @vedantmgoyal9 @russellbanks Any ideas?

from onefetch.

o2sh avatar o2sh commented on June 5, 2024

microsoft/winget-pkgs#145174 has been merged

@laurentkempe Can you try again?

from onefetch.

spenserblack avatar spenserblack commented on June 5, 2024

🤔 I'm curious why it ever mismatched to begin with. The installer hash was written by our release workflow, right?

from onefetch.

o2sh avatar o2sh commented on June 5, 2024

🤔 I'm curious why it ever mismatched to begin with. The installer hash was written by our release workflow, right?

That's right.

Beside, I don't understand how the initial PR - created by the CD - passed microsoft/winget-pkgs#144949, the hash mismatch should have been caught here 🤔

from onefetch.

spenserblack avatar spenserblack commented on June 5, 2024

Perhaps during CD we should also upload the executable as a workflow artificact, just so we can reference the artifact as the "real" file from the workflow. It would be a bit reassuring to compare the hashes between the artifact and the release asset in the future.

from onefetch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.