Comments (5)
@galibzon if you want to work on this for the upcoming release, we will need to do one of two things to make sure we track it properly either (A) move this issue into the main repo and assign it to the "Release/2210" milestone. OR (B) create a "Release/2210" milestone here in this repo and alert @AMZN-Dk and I that this milestone exists in this depot.
We are ok with either option. Thanks
from o3de-azslc.
Azslc is not supposed to accept preprocessor directives. So this report probably needs to be moved toward the repository where the builders are.
Just tested mcpp alone, and seems to be working:
If issue there indeed is, it has to be related to some treatment in the builders, like include list processing:
https://github.com/o3de/o3de/blob/6912c88b0892f8e68a7c42935cc6e5eb7d2b355e/Gems/Atom/Asset/Shader/Code/Source/Editor/CommonFiles/Preprocessor.cpp#L291
from o3de-azslc.
I've stumbled onto the same, if not similar, issue. My issue occurs with #include with angle brackets as well. My example below is using the shader code given in this tutorial: https://www.o3de.org/docs/learning-guide/tutorials/rendering/get-started-materialtypes-and-shaders/
When no empty line is present at the top of the .azsl file such as:
The following error is generated as though the "#include <viewsrg.srgi>" was not present:
However, when an empty line is placed at the top of the .azsl file as such:
No errors are generated in the Asset Processor by the Asset Builder.
from o3de-azslc.
I ran into this recently too, also with angle brackets. Moving it to the second line resolved the issue.
from o3de-azslc.
@galibzon We might want to consider prioritizing this fix for the upcoming release.
from o3de-azslc.
Related Issues (20)
- Command Line Namespace Option Consumes AZSL File Path
- Finalize AZSLc Changes To Support Bindless
- Update Documentation About AZSLc Packaging HOT 1
- Update AZSLc (and O3DE) To Support HLSL 2021 Features HOT 4
- Defaut setup ends up in 20/356 failed tests
- generate_mcpp.bat script seems to have stale paths
- DXC invocation tests lost
- `uint64_t` literal `ULL` handled incorrectly HOT 3
- [Info][Patch] Current O3DE is incompatible with current azslc HOT 1
- Generated files (from ANTLR) should be not be checked in HOT 3
- Emitted HLSL contains many unneeded new lines HOT 5
- Shader Option Priority HOT 3
- Release schedule HOT 2
- attribute before SRG mixes up inside comment
- `sample[x](uv)` not supported
- RFC - unconstrained language evolution HOT 9
- option range not reconstructed
- signed unsigned does not discrimate a type: problem for overloads!
- Is it possible to use inline raytracing? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from o3de-azslc.