GithubHelp home page GithubHelp logo

Comments (5)

tonybalandiuk avatar tonybalandiuk commented on May 20, 2024 1

@galibzon if you want to work on this for the upcoming release, we will need to do one of two things to make sure we track it properly either (A) move this issue into the main repo and assign it to the "Release/2210" milestone. OR (B) create a "Release/2210" milestone here in this repo and alert @AMZN-Dk and I that this milestone exists in this depot.

We are ok with either option. Thanks

from o3de-azslc.

siliconvoodoo avatar siliconvoodoo commented on May 20, 2024

Azslc is not supposed to accept preprocessor directives. So this report probably needs to be moved toward the repository where the builders are.

Just tested mcpp alone, and seems to be working:
image

If issue there indeed is, it has to be related to some treatment in the builders, like include list processing:
https://github.com/o3de/o3de/blob/6912c88b0892f8e68a7c42935cc6e5eb7d2b355e/Gems/Atom/Asset/Shader/Code/Source/Editor/CommonFiles/Preprocessor.cpp#L291

Or around here
https://github.com/o3de/o3de/blob/6912c88b0892f8e68a7c42935cc6e5eb7d2b355e/Gems/Atom/Asset/Shader/Code/Source/Editor/ShaderAssetBuilder.cpp#L110

from o3de-azslc.

CSteel22 avatar CSteel22 commented on May 20, 2024

I've stumbled onto the same, if not similar, issue. My issue occurs with #include with angle brackets as well. My example below is using the shader code given in this tutorial: https://www.o3de.org/docs/learning-guide/tutorials/rendering/get-started-materialtypes-and-shaders/

When no empty line is present at the top of the .azsl file such as:

image

The following error is generated as though the "#include <viewsrg.srgi>" was not present:

image

However, when an empty line is placed at the top of the .azsl file as such:
image

No errors are generated in the Asset Processor by the Asset Builder.

from o3de-azslc.

santorac avatar santorac commented on May 20, 2024

I ran into this recently too, also with angle brackets. Moving it to the second line resolved the issue.

from o3de-azslc.

santorac avatar santorac commented on May 20, 2024

@galibzon We might want to consider prioritizing this fix for the upcoming release.

from o3de-azslc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.