Comments (2)
We could solve the problem in our application by providing a custom Server
implementation.
I think it would be reasonable to add this change to the default implementation as well.
The relevant difference to the http_server_bun.ts
implementation is that we added an abort signal listener in the ReadableStream.start
function, that closes the stream AND the server:
listen(): Listener | Promise<Listener> {
if (this.#server) {
throw new Error("Server already listening.");
}
const { onListen, hostname, port, signal } = this.#options;
const tls = isServeTlsOptions(this.#options)
? { key: this.#options.key, cert: this.#options.cert }
: undefined;
const { promise, resolve } = createPromiseWithResolvers<Listener>();
this.#stream = new ReadableStream<BunRequest>({
start: (controller) => {
this.#server = Bun.serve({
fetch(req, server) {
const request = new BunRequest(req, server);
controller.enqueue(request);
return request.response;
},
hostname,
port,
tls,
});
signal?.addEventListener("abort", () => {
controller.close();
this.close();
}, { once: true });
{
const { hostname, port } = this.#server;
if (onListen) {
onListen({ hostname, port });
}
resolve({ addr: { hostname, port } });
}
},
});
return promise;
}
from oak.
Btw: The nodejs server implementation seems to suffer from the same issue.
from oak.
Related Issues (20)
- Breaking change in `request.body` handling not documented in v13 HOT 6
- No clear guidance on how to create a mock route context with body
- TypeError - ctx.request.body is not a function error while deploying to deno HOT 2
- https support broken since oak@13 HOT 2
- Error in the README: `test()` instead of `text()`
- Typo in README.md
- Use body and relay it via proxy middleware in oak v13+ HOT 1
- Proxied request secure?
- Controllers, why doesn't possible inject with private?
- More typing on Request and Response object? HOT 4
- request.body.text() causes error on localhost HOT 3
- Oak import causes a compiled app to hang HOT 1
- context.request.body is not a function
- ctx.request.body is not a function
- Application's State type error HOT 2
- A better way to handle pre-processed bodies by zod / joi / yup / ajv
- Use `:authority` psueod-header on HTTP/2 if available HOT 4
- Support `Forwarded` header as well as `X-Forwarded-*` HOT 1
- Exceptions from AsyncGenerator responses cause the connection to hang HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oak.