When selling 0.03 ETH worth of MKR transaction fails with misleading MM comment about oasis-direct

[luke7211]

The fix is obvious, what is more worrying to me is that there is a:

1. Totally unintuitive message from MetaMask. Clearly sth went wrong and we did not catch it beforehand
2. Even more troubling "Failed transaction probably due to exceeding 1% threshold" message - is there any way to differentiate that situation from other errors ?

[arkadiuszsz]

@luke7211 The really relevant part in MM message is the Transaction Error.
So when we do not allow situation where transaction would fail during gas estimation we should be on safe side (as far i can tell ).

[luke7211]

@deepinit-arek If there is an error during gas estimation the MM window should not pup up at all as we should have seen this error before. Why our gasEstimation() did not fail, but MM failed () ?

[arkadiuszsz]

@luke7211 I think You are right. Ill try to have closer look at this.

[gbalabasquer]

Need to review it in detail, but the minimum value is just an UI limit, a transaction failure has nothing to do with this limit.