Comments (5)
The fix is obvious, what is more worrying to me is that there is a:
- Totally unintuitive message from MetaMask. Clearly sth went wrong and we did not catch it beforehand
- Even more troubling "Failed transaction probably due to exceeding 1% threshold" message - is there any way to differentiate that situation from other errors ?
from oasis-direct.
@luke7211 The really relevant part in MM message is the Transaction Error
.
So when we do not allow situation where transaction would fail during gas estimation we should be on safe side (as far i can tell ).
from oasis-direct.
@deepinit-arek If there is an error during gas estimation the MM window should not pup up at all as we should have seen this error before. Why our gasEstimation() did not fail, but MM failed () ?
from oasis-direct.
@luke7211 I think You are right. Ill try to have closer look at this.
from oasis-direct.
Need to review it in detail, but the minimum value is just an UI limit, a transaction failure has nothing to do with this limit.
from oasis-direct.
Related Issues (20)
- Notification about completing conversion
- Rounding/Inputfield Issue
- What's the fifth paremeter in the offer function?
- Disclaimer box should have a different behaviour
- Oasis.direct 2 - Requirement List HOT 1
- Landing page - Adding Navigation HOT 1
- Tax Exporter Wireframes HOT 2
- Oasis Direct 2 - Design HOT 1
- Filled Inputfields should be truncated to 5 decimals
- Change message - transaction is taking longer
- Calculating gas cost is triggered on each new digit entered
- Input fields getting cleared
- Oasis.Direct Technical Documentation HOT 3
- Recalculation of price after prolonged period of user's inactivity
- Transaction execution error on gas cost calculation HOT 1
- FAQ Design
- CSV file with information about past trades
- Adblockers can cause Export Trades to fail HOT 3
- Oasis Direct as Widget that can be Embedded
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oasis-direct.