GithubHelp home page GithubHelp logo

Comments (3)

nhynes avatar nhynes commented on August 23, 2024 1

This is a problem with all of the precompiles, though. The upcoming hardhat precompiles will fix the problem when sapphire-hardhat is used, though not otherwise, but then that's just due to not following the instructions. I'd say for now we should wait for the hardhat precompiles. If you want, you could add a function like

function isSapphire() external view returns (bool) {
    return block.chainid == 0x5aff || block.chainid == 0x5afe;
}

and then call that in your contract's constructor

from sapphire-paratime.

nhynes avatar nhynes commented on August 23, 2024

Thanks for the report. A precondition of Sapphire.sol is that it's used in a Sapphire-like environment, so it's not a goal of this library to check that it's being called correctly. Do you know of a way to emit a compile-time error if it's not being used correctly? I would accept a change that avoids adding gas cost to each invocation.

from sapphire-paratime.

CedarMist avatar CedarMist commented on August 23, 2024

I don't think there's any way to perform a check at compile-time.

I ran into this same problem when first starting with Sapphire, and have seen it encountered again on Discord.

The gas cost of additional checks is minimal, instead of the existing "require()" with error message, both status & length check could be combined into a check, with a more generic per-function error?

if ( false == success || entropy.length != numBytes ) revert Precompile_RandomBytes_Error();

from sapphire-paratime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.