Remove DEFAULT_GAS once gas estimation is available about sapphire-paratime

[kostko]

Yes, this is now supported, although for gas estimation will currently always zeroize the sender in order to avoid it being used to bypass access control and potentially exposing secret data through a side channel. The problem is that estimate gas queries are not signed, so you cannot authenticate the caller.

For this reason, when execution fails during gas estimation, the estimate will currently be artifically inflated to account for the fact that access control checks are usually in the front (as otherwise the estimate would be an underestimate most of the time). This is not ideal and needs some more thought.

[CedarMist]

Currently the JS and Go compat APIs return a hard-coded amount when asked to estimate gas.

See:

sapphire-paratime/clients/js/src/compat.ts

Line 171 in 2ee5b38

estimateGas: () => DEFAULT_GAS,

sapphire-paratime/clients/go/compat.go

Line 231 in 2ee5b38

// EstimateGas implements ContractTransactor.

However, the implementation of eth_estimateGas in oasis-web3-gateway seems to have a full implementation.

See:
https://github.com/oasisprotocol/oasis-web3-gateway/blob/2fa2ad9f5170260324db51daca4638d346e43c91/rpc/eth/api.go#L483

Need to double check gas estimation works as expected, then re-enable it.

[aefhm]

For this reason, when execution fails during gas estimation, the estimate will currently be artifically inflated to account for the fact that access control checks are usually in the front (as otherwise the estimate would be an underestimate most of the time). This is not ideal and needs some more thought.

I vote this is an okay present day solution.

[CedarMist]

If you're not using signed queries, and passing explicit authentication to the function (e.g. an EIP-712 signature, username/password, WebAuthN attestation) this will not be a problem.