`FileCache` on an `AsyncClient` doesn't work with `s3fs` about httpx-cache

[obendidi]

Hey @mjkanji,

Thanks for opening the issue, I'll have a more detailed look later when I have the time :)

First question, does UPath support async operations ?

It makes sense for it not to work with the async client, since we wrap the pathlib.Path object with an anyio.Path wrapper to add async I/O ops:

httpx-cache/httpx_cache/cache/file.py

Lines 67 to 78 in adbbeda

	async def aget(self, request: httpx.Request) -> tp.Optional[httpx.Response]:
	filepath = anyio.Path(
	get_cache_filepath(self.cache_dir, request, extra=self._extra)
	)
	async with self.async_lock.reader:
	if await filepath.is_file():
	try:
	cached = await filepath.read_bytes()
	return self.serializer.loads(request=request, cached=cached)
	except Exception:
	return None
	return None

It works with the sync client since we use the user provided path directly.

[obendidi]

A new version has been released with async support for UPath, let me know if it works out to close the issue :)

https://obendidi.github.io/httpx-cache/guide/#fsspecuniversal_pathlib-integration

[mjkanji]

A new version has been released with async support for UPath, let me know if it works out to close the issue :)

It is working, indeed! Thank you for the quick fix!

A quick clarification: does this also work for the (Async)CacheControlTransport or just the clients?

[obendidi]

should work for everything, the clients use the CacheControlTransport inside

[mjkanji]

Awesome, thanks!