Comments (4)
Solved your case, but there might be other uses with ui-router that still has issues. It was firing events like crazy so I just skipped them and resorted to only $locationChangeSuccess
. If you have a failing example (most likely if state changes but not location), please post a new plunker :-)
from angular-scroll.
Please, see example without ui-router:
http://plnkr.co/edit/C5YZ6ZHVjGpsR0GXkUWu?p=preview
In this case template including scroll spy is loaded via ngInclude and thus does not change location.
Here is the plunker that works with ui-router as well as with the example above.
http://plnkr.co/edit/OnhOIoNw7q14fPcNm1dY?p=preview
It contains only one change against original code (before fix #41). See line 282 in plunker:
if (!context.container || (context.container && !$.contains(document.documentElement, context.container[0]))) {
This line provides rebinding anytime container does not exist in DOM.
from angular-scroll.
Your plunker introduces a jQuery dependency which I'm not comfortable with. Reverted previous changes and used a pure js implementation instead.
from angular-scroll.
It is better without jQuery for sure. Thanks!
from angular-scroll.
Related Issues (20)
- [Request] Define Scroll Container when triggering from controller HOT 1
- Strange Safari-only issue – scroll won't work with css transition HOT 2
- Scroll within IFrame isn't working HOT 1
- Is it possible to get the id of the element currently scrolled to?
- On a new view loaded, scrollToElementAnimated doesn't work. HOT 1
- [Request] Scroll Interrupt Threshold
- .scrollTo scrolling to 0 on X axis instead of other way
- scrollToElementAnimated not supported for horizontal scrolling?
- New version 1.0.1 not working for me HOT 4
- Bower file has an error
- du-scrollspy work's just on loading HOT 1
- angular 2+ version?
- Not Working in 1.6 version HOT 4
- Configuration?
- Why is there a 20 offset for determining position?
- Possibly unhandled rejection: undefined HOT 1
- support angular2+?
- Using same ID for scroll container across different views breaks scrolling
- Please update name of the project to angular js.
- Bottom spy isn't great with short pages HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-scroll.