GithubHelp home page GithubHelp logo

Comments (4)

oblador avatar oblador commented on May 20, 2024

Solved your case, but there might be other uses with ui-router that still has issues. It was firing events like crazy so I just skipped them and resorted to only $locationChangeSuccess. If you have a failing example (most likely if state changes but not location), please post a new plunker :-)

from angular-scroll.

r0610205 avatar r0610205 commented on May 20, 2024

Please, see example without ui-router:
http://plnkr.co/edit/C5YZ6ZHVjGpsR0GXkUWu?p=preview

In this case template including scroll spy is loaded via ngInclude and thus does not change location.

Here is the plunker that works with ui-router as well as with the example above.
http://plnkr.co/edit/OnhOIoNw7q14fPcNm1dY?p=preview
It contains only one change against original code (before fix #41). See line 282 in plunker:

if (!context.container || (context.container && !$.contains(document.documentElement, context.container[0]))) {

This line provides rebinding anytime container does not exist in DOM.

from angular-scroll.

oblador avatar oblador commented on May 20, 2024

Your plunker introduces a jQuery dependency which I'm not comfortable with. Reverted previous changes and used a pure js implementation instead.

from angular-scroll.

r0610205 avatar r0610205 commented on May 20, 2024

It is better without jQuery for sure. Thanks!

from angular-scroll.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.