Timeout fail on CircleCI about loki

[sampaiodiego]

I was only able to run loki on CircleCI using an image with Chrome and node installed and then running loki on chrom.app instead of chrome.docker.

[oblador]

Think this is related to #92 and #90

[jagregory]

I'm seeing the same issue with CircleCI. Could it be related to the way Docker networking is setup in Circle? https://circleci.com/docs/2.0/building-docker-images/#separation-of-environments That sounds suspiciously like Loki wouldn't be able to connect directly to the Chrome containers, right?

[dbartholomae]

I actually get the following error message:

[01:29:21] → Command failed: docker images -q yukinying/chrome-headless:63.0.3230.2
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

Will investigate more.

[dbartholomae]

@oblador My naive approach would be to set up an additional target that doesn't spin up docker, but instead connects to a predefined docker container. This would require users that set up CircleCI to ensure the correct container is running and is reachable, but to be honest I don't see a good way to spin up the docker container from inside a CircleCI command. I'll experiment with this and hopefully provide a PR :)

[oblador]

@dbartholomae Looking forward to it!

[dbartholomae]

@oblador I've played around with some concepts and in the end came up with the following thoughts:
Instead of having a separate target the original target needs to be able to switch over to using an already running Docker container. Otherwise the user of loki would need to run different target configs on CI and local, which is bound to lead some false positives in the tests.
Here's my current code:
https://github.com/dbartholomae/loki/tree/add_remote_chrome_target

It's not done yet, currently I'm stuck with two issues, one being that I cannot run it on windows because the Docker container cannot connect to the webserver running on host that has storybook in it. The other (and in my opinion more important) issue is that on Linux all screenshots are taken from the same page, so it seems the iframe isn't loaded correctly. I'll most likely continue working on this next weekend.

[kristof-mattei]

#218 to wait little longer when loading storybooks seems to help A lot.

[ianhansborough]

I was only able to run loki on CircleCI using an image with Chrome and node installed and then running loki on chrom.app instead of chrome.docker.

Which image did you use for this? I had a similar thought, but I'm still seeing differences in ~20% of my screenshots.

[remleduff]

This could potentially be fixed by #478