Make addon official about ddev-minio

[tyler36]

I'm using Docker Desktop and running DDEV in WSL2 currently.
DD says "You are using the WSL 2 backend, so resource limits are managed by Windows."

I have .wslconfig set limit CPU to 2:

[wsl2]
processors=2 # Makes the WSL 2 VM use two virtual processors

I guess I can play around with that later.

[stasadev]

I will review this add-on next week.

Error response from daemon: Range of CPUs is from 0.01 to 2.00, as there are only 2 CPUs available

Capping it to below 2 CPUs will make it unusable.

I guess the 2.5 doesn't work for everybody.

I checked and 1.99 can be used instead 🙂

[rfay]

/cc @stasadev - I guess the 2.5 doesn't work for everybody.

[rfay]

Thanks for your work on this.

Just a casual look around... it doesn't seem like the tests run on several different situations. For example, the most recent commit didn't run tests, https://github.com/oblakstudio/ddev-minio/commits/master/ - Why is that? (I'm glad to see the daily tests will run now, but they haven't run automatically yet...)

Are you now subscribed to get notifications of test failures?

[rfay]

@tyler36 @stasadev would you mind doing a review of this add-on before it becomes official? Thanks!

[tyler36]

Not sure if there's configuration I'm missing, but my project doesn't start:

DDEV: v1.23.0
ddev-minio: v2.0.2

Test

1. Confirm DDEV project working

$ ddev start  
...
Project can be reached at https://30days-l11-demo.ddev.site https://127.0.0.1:52787 

1. Install addon

$ ddev get oblakstudio/ddev-minio
...
Installed minio:v2.0.2 from oblakstudio/ddev-minio 

1. Restart project

$ ddev restart
......Project images built in 6s. 
 Network ddev-30days-l11-demo_default  Created 
 Volume "ddev-30days-l11-demo-minio"  Created 
Error response from daemon: Range of CPUs is from 0.01 to 2.00, as there are only 2 CPUs available 

[rfay]

@tyler36 you can probably fix this just by changing your docker cpu reservation to something higher than the default 2 I guess? I bet your machine has plenty of threads available.

[seebeen]

Running MinIO without any limits can cause it to takeover the entire CPU because it's both CPU and memory hungry. Capping it to below 2 CPUs will make it unusable. I'm assuming that anyone who uses docker has more than 2 CPU cores at their disposal.