GithubHelp home page GithubHelp logo

Comments (9)

linikujp avatar linikujp commented on June 2, 2024 2

I agree that CEMO's focus on COVID-19 can be seen as a use case of epidemiological and monitoring ontology in COVID-19.
@NuriaQueralt Can we change the name to Community or Common Epidemiology and Monitoring Ontology? You could keep the CEMO, but transform it to a broader sense.
I am the part of the team of this ontology. I agree that @cmungall comments make sense.
We'd like to reserve the namespace CEMO while we are reaching out other ontologies and coordinate.

from obofoundry.github.io.

cmungall avatar cmungall commented on June 2, 2024

I notice that your ontology injects a lot of axioms into existing ontologies:

  • [] BFO:0000019 quality
    • [i] obo:CEMO_0000126 ! quantitative quality
      • [i] obo:VIDO_0001331 ! viral load
      • [i] obo:COVOC_0010003 ! confirmed cases
      • [i] obo:CEMO_0000125 ! quarantined cases
      • [i] obo:CEMO_0000122 ! new daily cases
      • ...
      • [snip]
      • ...
      • [i] obo:CEMO_0000004 ! quantity of infected population
      • [i] obo:CEMO_0000003 ! infection fatality rate
      • [i] obo:CEMO_0000002 ! hospital-wide nosocomial infection rate per 100 admissions
      • [i] obo:CEMO_0000001 ! number of cases removed from isolation this week
      • [i] VO:0000247 ! vaccine efficacy
      • [i] STATO:0000424 ! risk difference
      • [i] STATO:0000414 ! mortality rate
      • [i] STATO:0000412 ! prevalence
      • [i] STATO:0000245 ! relative risk
      • [i] STATO:0000233 ! sensitivity
      • [i] STATO:0000182 ! odds ratio
      • [i] STATO:0000134 ! diagnostic specificity
      • [i] STATO:0000088 ! study group population size
      • [i] PATO:0001415 ! morbidity
      • [i] ORDO:409966 ! point prevalence
      • [i] OBCS:0000064 ! period prevalence
      • [i] OBCS:0000052 ! incidence proportion ratio
      • [i] OAE:0001869 ! recovery rate
      • [i] NCIT:C67448 ! infectious dose
      • [i] NCIT:C17734 ! at-risk population
      • [i] NCIT:C164607 ! gene sequence identity
      • [i] NCIT:C164332 ! sequence identity of sample
      • [i] IDO:0001343 ! latency period
      • [i] IDO:0000519 ! incubation period
      • [i] IDO:0000484 ! infection incidence rate
      • [i] IDO:0000482 ! incidence proportion
      • [i] IDO:0000467 ! susceptibility
      • [i] IDO:0000466 ! virulence
      • [i] IDO:0000463 ! transmission probability
      • [i] GSSO:006827 ! fertility rate
      • [i] EFO:0004804 ! birth rate
      • [i] APOLLO_SV:00000569 ! total number of cases
      • [i] APOLLO_SV:00000568 ! total number of deaths
      • [i] APOLLO_SV:00000497 ! number of cases new this week
      • [i] APOLLO_SV:00000449 ! quarantine period
      • [i] APOLLO_SV:00000163 ! recovered cases
      • [i] APOLLO_SV:00000140 ! infectious period
      • [i] APOLLO_SV:00000002 ! basic reproduction number
      • [i] http://purl.unep.org/sdg/SDGIO_00020030 ! neonatal mortality rate

OBO operations has not yet achieved consensus on best practices for axiom injection (#1443), so my comments do not reflect official OBO views. In the past this has caused a lot of issues as it is easy to arrive at a situation with conflicts.

For example, you inject APOLLO_SV:00000569 under BFO quality, but this conflicts with what is in APOLLO_SV:

image

so merging these ontologies results in a conflict:

robot merge -i cemo.owl -I $OBO/apollo_sv.owl reason -r elk
2023-03-22 14:40:22,622 ERROR org.obolibrary.robot.ReasonerHelper - There are 23 unsatisfiable classes in the ontology.
2023-03-22 14:40:22,627 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/apollo_sv/dev/apollo_sv.owl#APOLLO_SV_00000002
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/apollo_sv/dev/apollo_sv.owl#APOLLO_SV_00000001
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/apollo_sv/dev/apollo_sv.owl#APOLLO_SV_00000003
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000449
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000568
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000569
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/CEMO_0000064
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/IDO_0000519
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000002
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/STATO_0000088
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000140
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000382
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000163
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000383
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/STATO_0000245
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/IDO_0001343
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000381
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000016
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000277
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000497
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000498
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/STATO_0000134
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/STATO_0000233

I would recommend that you have transparent (i.e github issue) bilateral discussions with the relevant ontologies where if you either disagree with their placement or want to otherwise inject there is clear ongoing discussion about this.

I note you have also injected an axiom subClassOf 'quality of' some 'spatial region' into IDO infection incidence rate. This is a pretty odd axiom, it didn't seem to original with IDO, and it will also cause inference issues.

I also note that that many of your terms seem out of scope for a covid ontology. What happens if say apollo sv or IDO or another ontology wants to add a term "infection fatality rate"? Are they obliged to check all ontologies in OBO including CEMO? What is the SOP if it is determined it is in scope for apollo_sv? Is the term adopted or is the CEMO term obsoleted and replaced by an apollo_sv term?

I want to be clear to other members of OBO-operations here: the problems I note are prevalent with many other OBO ontologies, so I don't think CEMO should be held to a different standard. But I want to underscore the importance of other members of OBO being supportive of proactively solving some of these issues

from obofoundry.github.io.

pfabry avatar pfabry commented on June 2, 2024

Hi @NuriaQueralt,

Thank you for your submission. The review for new ontologies will be executed as a two stage process.

  • First, you will have to pass OBO NOR Dashboard. Pass means that no check apart from Users may be red.
  • After you have successfully passed the Dashboard you will be assigned an OBO Operations committee member to review the ontology.

You will be informed once your ontology is loaded in the OBO NOR Dashboard. All communications should take place in the present issue.

I see that you have already reserved the namespace with Bioregistry. Please let me know if you want to postpone your submission to the NOR dahsboard considering the issues raised above.

from obofoundry.github.io.

NuriaQueralt avatar NuriaQueralt commented on June 2, 2024

Hi @cmungall @linikujp @pfabry,

Thank you very much for your fast feedback.

@cmungall your analysis is super useful! we are currently drafting a more accurate modelling of domain knowledge that have already addressed some of these logical inconsistencies. When finished, we think that will resolve them.

@linikujp this is a great idea and we support it.

@pfabry I am asking the CEMO team about postponing our submission to the NOR dashboard. I will get back to you asap. A question, what happens if our ontology fails to pass some points? will we have the chance to address them and try again?

from obofoundry.github.io.

pfabry avatar pfabry commented on June 2, 2024

A question, what happens if our ontology fails to pass some points? will we have the chance to address them and try again?

Yes, of course :) It's more a back and forth process whose purpose is to ensure an ontology follows OBO foundry's principles.

from obofoundry.github.io.

NuriaQueralt avatar NuriaQueralt commented on June 2, 2024

Hi @pfabry

We would like to postpone our submission to the NOR dahsboard considering the issues raised above. How should I proceed once we address the issues and feel ready to restart the submission?

from obofoundry.github.io.

pfabry avatar pfabry commented on June 2, 2024

Hi @NuriaQueralt

I would advise you to close this issue and open a new one once you're ready.

from obofoundry.github.io.

NuriaQueralt avatar NuriaQueralt commented on June 2, 2024

Hi @pfabry ,

Thank you very much!

from obofoundry.github.io.

pfabry avatar pfabry commented on June 2, 2024

Feel free to reopen this issue or create a new one when you are ready to submit.

from obofoundry.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.